Greenwave: query both contexts for critpath updates (#4259)

[AdamWill]

As discussed in #4259 and also reported in
https://pagure.io/fedora-ci/general/issue/263 , my previous
change to have Bodhi query on a different Greenwave 'decision
context' for critical path updates - allowing us to gate
critpath updates on openQA test results - caused a problem with
package-specific gating policies. The instructions and examples
for writing these only include the original decision contexts
(bodhi_update_push_testing and bodhi_update_push_stable), they
do not also recommend including the _critpath contexts, and
this is indeed how all real-world package-specific policies have
been written. This has resulted in package-specific policies
being effectively ignored when the package in question is a
part of a critical path update, because Bodhi is querying on
the _critpath context but the package-specific policy doesn't
include it.

To avoid this problem, this change makes Bodhi query greenwave
on both relevant contexts for critical path updates. The logic
for parsing the results doesn't need to change because we were
already coping with multiple queries for the case where an
update has too many subjects for a single query.

This does change the behaviour of one method -
Update.get_test_gating_info() - and one API endpoint -
/updates/{id}/get-test-results . These now both return lists
of Greenwave decision dicts, rather than a single Greenwave
decision dict. There's no way I can see to maintain behaviour
here, and the existing behaviour was already wrong for updates
with lots of packages (this method and endpoint should have
been adjusted when we initially implemented batched requests
for such updates, but they were missed). I don't think the method
or the endpoint were commonly used.

Signed-off-by: Adam Williamson awilliam@redhat.com

[AdamWill]

I don't think the failed tests relate to the PR. Something to do with fedora-messaging in the integration test environment.

[thrix]

LGTM, did not find anything worth commenting

[mattiaverga]

I don't think anything else other than Bodhi uses that API endpoint, so I think we can safely change the output.

Since we're still in freeze and Bodhi 5.7.1 is still in staging, I think it could be nice to have this pushed into the next release.

[AdamWill]

I don't think anything else other than Bodhi uses that API endpoint, so I think we can safely change the output.

Since we're still in freeze and Bodhi 5.7.1 is still in staging, I think it could be nice to have this pushed into the next release.

yes, we absolutely want this in the next release and we want the next release out ASAP, as the problem is causing real pain for people trying to use the package-specific policies. sorry about that!

[psss]

Thanks for the fix, @AdamWill.