Fix two bugs. #207
Merged
Fix two bugs. #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphbean
force-pushed
the
pesky-error-handling
branch
from
9ce50a0
to
0daa568
Compare
First, the value of `start` could be None here, which causes the error seen in #206. Furthermore, it turns out that the `flask` module has no `BadRequest` exception there. It is really in `werkzeug.exceptions`. Use that. Lastly, this adds a test, which we really should've added in #197 and *really* should've added in #204.
ralphbean
force-pushed
the
pesky-error-handling
branch
from
0daa568
to
71d8ef8
Compare
mprahl
reviewed
Apr 17, 2018
| if contains and datetime.fromtimestamp(start) < (datetime.utcnow() - timedelta(weeks=4*8)): | ||
| raise flask.BadRequest('When using contains, specify a start at most ' | ||
| 'eight months into the past') | ||
| if contains and datetime.fromtimestamp(start or 0) < (datetime.utcnow() - timedelta(weeks=4*8)): |
There was a problem hiding this comment.
This isn't technically eight months 😛
|
👍 |
|
Thanks Matt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, the value of
startcould be None here, which causes the error seen in #206. Furthermore, it turns out that theflaskmodule has noBadRequestexception there. It is really inwerkzeug.exceptions. Use that.Lastly, this adds a test, which we really should've added in #197 and really should've added in #204.