groups with no members or sponsors causes 500

[nirik]

Similar to #399 if there is a group with no members/sponsors, fasjson returns a 500:

[Mon Feb 20 19:04:11.774116 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354] [2023-02-20 19:04:11,772] ERROR in app: Exception on /v1/groups/gitlab-centos-sig-altimages/sponsors/ [GET]
[Mon Feb 20 19:04:11.774150 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354] Traceback  (most recent call last):
[Mon Feb 20 19:04:11.774153 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354]   File "/opt/venv/lib64/python3.10/site-packages/flask/app.py", line 1517, in full_dispatch_request
[Mon Feb 20 19:04:11.774156 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354]     rv = self.dispatch_request()
[Mon Feb 20 19:04:11.774158 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354]   File "/opt/venv/lib64/python3.10/site-packages/flask/app.py", line 1503, in dispatch_request
[Mon Feb 20 19:04:11.774161 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354]     return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
[Mon Feb 20 19:04:11.774164 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354]   File "/opt/venv/lib64/python3.10/site-packages/flask_restx/api.py", line 403, in wrapper
[Mon Feb 20 19:04:11.774167 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354]     resp = resource(*args, **kwargs)
[Mon Feb 20 19:04:11.774170 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354]   File "/opt/venv/lib64/python3.10/site-packages/flask/views.py", line 84, in view
[Mon Feb 20 19:04:11.774179 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354]     return current_app.ensure_sync(self.dispatch_request)(*args, **kwargs)
[Mon Feb 20 19:04:11.774187 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354]   File "/opt/venv/lib64/python3.10/site-packages/flask_restx/resource.py", line 49, in dispatch_request
[Mon Feb 20 19:04:11.774194 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354]     resp = meth(*args, **kwargs)
[Mon Feb 20 19:04:11.774201 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354]   File "/opt/venv/lib64/python3.10/site-packages/flask_restx/marshalling.py", line 248, in wrapper
[Mon Feb 20 19:04:11.774208 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354]     resp = f(*args, **kwargs)
[Mon Feb 20 19:04:11.774214 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354]   File "/fasjson/fasjson/web/resources/groups.py", line 107, in get
[Mon Feb 20 19:04:11.774220 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354]     return client.get_group_sponsors(
[Mon Feb 20 19:04:11.774228 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354]   File "/fasjson/fasjson/lib/ldap/client.py", line 110, in get_group_sponsors
[Mon Feb 20 19:04:11.774234 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354]     return self._sponsors_to_users(sponsors_result, attrs)
[Mon Feb 20 19:04:11.774239 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354]   File "/fasjson/fasjson/lib/ldap/client.py", line 116, in _sponsors_to_users
[Mon Feb 20 19:04:11.774246 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354]     username = re.findall("(?<=uid=)([^,]+)", sponsor)[0]
[Mon Feb 20 19:04:11.774251 2023] [wsgi:error] [pid 5882:tid 5885] [remote 10.131.0.1:44354] IndexError: list index out of range

I would think it should return 0 or [] or something. ;)

[nirik]

It turns out the group did have managers... but it was... another group and fasjson doesn't know what to do with that.

So, it should likely look and if there's groups that are managers, query for their members and return all of them?

Or just return the group(s) with some indication it's a group and not a user?

[LenkaSeg]

Steps to reproduce:

Start tiny-stage:
vagrant up

Go to https://ipa.tinystage.test/ipa
Log in as admin, password: password

Add group in the UI

Set up the authentication as described in tiny-stage readme:
echo password | KRB5_CONFIG=krb5.conf kinit admin

curl to fasjson tiny-stage:
KRB5_CONFIG=krb5.conf curl --cacert ./synced_folders/ipa/ca.crt -u : --negotiate https://fasjson.tinystage.test/fasjson/v1/me/

Add group member managers => User Groups => add a group

Query fasjson:
KRB5_CONFIG=krb5.conf curl --cacert ./synced_folders/ipa/ca.crt -u : --negotiate https://fasjson.tinystage.test/fasjson/v1/me/`

Query group:
KRB5_CONFIG=krb5.conf curl --cacert ./synced_folders/ipa/ca.crt -u : --negotiate https://fasjson.tinystage.test/fasjson/v1/groups/test-group/sponsors/

Result:
{"message": "Internal Server Error"}

Working on a fix :)