Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A diagram for how fedbadges relates to the other badges.fp.o pieces. #48

Merged
merged 3 commits into from
Mar 9, 2016

Conversation

ralphbean
Copy link
Contributor

@pypingou
Copy link
Member

pypingou commented Mar 9, 2016

Looks good to me, my only comment would be if we could find a way to have only one tahrir api block instead of 4.

@ralphbean
Copy link
Contributor Author

Hm. Maybe I can make it work.. but I don't want to accidentally convey the mistaken notion that tahrir api is a service that all the other services interact with. It's a module that ends up being embedded in all the other processes, which they use to interact with the DB in a hopefully consistent way.

@ralphbean
Copy link
Contributor Author

Yeah - thinking over it more, @pypingou I'd really like to keep the blocks separate -- again, just to convey that tahrir-api is not a service, but a library.

ralphbean added a commit that referenced this pull request Mar 9, 2016
…-thousand-words

A diagram for how fedbadges relates to the other badges.fp.o pieces.
@ralphbean ralphbean merged commit 2ac6398 into develop Mar 9, 2016
@ralphbean ralphbean deleted the feature/a-picture-is-worth-a-thousand-words branch March 9, 2016 16:34
@pypingou
Copy link
Member

pypingou commented Mar 9, 2016

ok wfm, 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants