Pungi4 fixes. #47
Merged
Pungi4 fixes. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphbean
force-pushed
the
feature/pungi4-fixes
branch
from
b7038ea
to
fa98934
Compare
With pungi4 we changed the way images are being created in koji. They're no longer scratch tasks .. they're instead attached to a real 'build'. https://fedorahosted.org/rel-eng/ticket/6304 This updates the code to handle both scenarios (images as scratch tasks and images as real builds). It seems we're still producing a small handful of them the old way.
ralphbean
force-pushed
the
feature/pungi4-fixes
branch
from
fa98934
to
aec9980
Compare
|
|
||
| log.info('Received %r %r' % (msg['topic'], msg['body']['msg_id'])) | ||
| if len(builds) > 0: | ||
| fedimg.uploader.upload(self.upload_pool, |
There was a problem hiding this comment.
Do we want to log what we upload?
There was a problem hiding this comment.
Might as well, yes. There are some log statements inside service.upload... but they get called later on. Could be useful to log the urls here too, yes. I'll do it as a separate PR.
|
One question, otherwise 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With pungi4 we changed the way images are being created in koji. They're no longer scratch tasks .. they're instead attached to a real 'build'.
https://fedorahosted.org/rel-eng/ticket/6304
This updates the code to handle both scenarios (images as scratch tasks and images as real builds). It seems we're still producing a small handful of them the old way.