Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the module name as the logger name #441

Closed
jeremycline opened this issue Jul 5, 2017 · 4 comments
Closed

Use the module name as the logger name #441

jeremycline opened this issue Jul 5, 2017 · 4 comments
Labels

Comments

@jeremycline
Copy link
Member

We should change all fedmsg logging to occur from a logger acquired using logging.getLogger(__name__) (the recommended practice in the Python logging documentation).

There's loggers using the package name ("fedmsg"), a package name outside of fedmsg ("moksha"), and logging instances are being passed around/stored on objects. This makes it much more annoying to track down where logs are being emitted, and also makes configuration unnecessarily difficult.

@cha-ku
Copy link
Contributor

cha-ku commented Sep 3, 2017

Hi @jeremycline , I would like to work on this issue. Could you please assign this to me?

@jeremycline
Copy link
Member Author

I don't think I can assign it to you since you're not part of the fedora-infra GitHub organization. I think commenting here is enough to let people know you're working on it.

@cha-ku
Copy link
Contributor

cha-ku commented Sep 7, 2017

Alright then. Will work on this. Thanks! :)

@jeremycline
Copy link
Member Author

Fixed in #479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants