-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated meetbot.meeting.info.topic to the meetbot docs #338
Conversation
@@ -475,7 +475,7 @@ class TestSupybotMeetingItemLink(Base): | |||
"meeting_topic": "Server SIG Weekly Meeting (2015-06-23)", | |||
"owner": "nirik", | |||
"topic": "Open Floor", | |||
"url": "http://meetbot.fedoraproject.org/fedora-meeting-1/" | |||
"url": "http://meetbot.fedoraproject.org/fedora-meeting-1/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary extra newline at the end of the line here.
Looks like a good approach in general. As mentioned in IRC, the test suite found a syntax error in this code, so.. try fixing that up and running the test suite on your own box with |
Should the commits be squashed ? (especially considering they all have the same message) |
@bee2502 any updates on this one? |
Hi, Bee On Mon, Nov 2, 2015 at 7:53 PM, Ralph Bean notifications@github.com wrote:
|
Sure! No problem. Just checking in :) |
Hi @bee2502 can we help with something for this PR? |
OK, I'm going to close this for now to get it out of our review-queue. @bee2502, if you want to pick up work on it again, feel free to re-submit it -- the change is welcome, once we can iron out the test suite. |
Link for the issue : #337