Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated meetbot.meeting.info.topic to the meetbot docs #338

Closed
wants to merge 5 commits into from

Conversation

bee2502
Copy link

@bee2502 bee2502 commented Oct 28, 2015

Link for the issue : #337

@@ -475,7 +475,7 @@ class TestSupybotMeetingItemLink(Base):
"meeting_topic": "Server SIG Weekly Meeting (2015-06-23)",
"owner": "nirik",
"topic": "Open Floor",
"url": "http://meetbot.fedoraproject.org/fedora-meeting-1/"
"url": "http://meetbot.fedoraproject.org/fedora-meeting-1/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary extra newline at the end of the line here.

@ralphbean
Copy link
Contributor

Looks like a good approach in general.

As mentioned in IRC, the test suite found a syntax error in this code, so.. try fixing that up and running the test suite on your own box with python setup.py test. It should check to make sure everything works out before you submit more commits.

@pypingou
Copy link
Member

Should the commits be squashed ? (especially considering they all have the same message)

@ralphbean
Copy link
Contributor

@bee2502 any updates on this one?

@bee2502
Copy link
Author

bee2502 commented Nov 2, 2015

Hi,
I have been working on my Outreachy application for the past few days(Today
is the deadline). Just give me a day more with the docs ?

Bee

On Mon, Nov 2, 2015 at 7:53 PM, Ralph Bean notifications@github.com wrote:

@bee2502 https://github.com/bee2502 any updates on this one?


Reply to this email directly or view it on GitHub
#338 (comment)
.

@ralphbean
Copy link
Contributor

Sure! No problem. Just checking in :)

@pypingou
Copy link
Member

Hi @bee2502 can we help with something for this PR?

@ralphbean
Copy link
Contributor

OK, I'm going to close this for now to get it out of our review-queue. @bee2502, if you want to pick up work on it again, feel free to re-submit it -- the change is welcome, once we can iron out the test suite.

@ralphbean ralphbean closed this Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants