Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update openQA processor and tests for comment messages #408

Merged
merged 1 commit into from Dec 6, 2016

Conversation

Projects
None yet
3 participants
@AdamWill
Copy link
Contributor

commented Dec 1, 2016

Upstream openQA has added fedmsg messages for comments, so we
should handle them in the processor.

Note: the tests just completely blow up when I try to run them here (on Rawhide), so I threw the necessary bits into a test script to test this. I think it should be OK.

@AdamWill

This comment has been minimized.

Copy link
Contributor Author

commented Dec 1, 2016

Oh, yeah - openQA has an icon now, but I need someone to upload it to the URL I specified. Here's a PNG file of the image (it's SVG native):
Icon

@ralphbean

This comment has been minimized.

Copy link
Contributor

commented Dec 1, 2016

The icon goes here. :)

@AdamWill

This comment has been minimized.

Copy link
Contributor Author

commented Dec 1, 2016

aha, thanks.

@ralphbean
Copy link
Contributor

left a comment

Looks good to me.

@AdamWill

This comment has been minimized.

Copy link
Contributor Author

commented Dec 1, 2016

thanks! what has to happen for it to get merged?

@ralphbean

This comment has been minimized.

Copy link
Contributor

commented Dec 1, 2016

I'm not sure.. I don't have rights to merge it myself anymore.

update openQA processor and tests for comment messages
Upstream openQA has added fedmsg messages for comments, so we
should handle them in the processor.

@AdamWill AdamWill force-pushed the AdamWill:openqa-update branch from 40ccb4f to a022973 Dec 5, 2016

@AdamWill

This comment has been minimized.

Copy link
Contributor Author

commented Dec 5, 2016

Just tweaked a bit for some changes to the messages (some merged upstream already, some in os-autoinst/openQA#1065 which I am backporting to the Fedora package).

@AdamWill

This comment has been minimized.

Copy link
Contributor Author

commented Dec 5, 2016

@tyll @pypingou can someone please review/merge this? thanks!

@pypingou

This comment has been minimized.

Copy link
Member

commented Dec 6, 2016

Let's merge, sorry for the delay! :)

@pypingou pypingou merged commit 6e3d9f5 into fedora-infra:develop Dec 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.