update openQA processor and tests for comment messages #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, yeah - openQA has an icon now, but I need someone to upload it to the URL I specified. Here's a PNG file of the image (it's SVG native): |
|
The icon goes here. :) |
|
aha, thanks. |
|
thanks! what has to happen for it to get merged? |
|
I'm not sure.. I don't have rights to merge it myself anymore. |
Upstream openQA has added fedmsg messages for comments, so we should handle them in the processor.
AdamWill
force-pushed
the
openqa-update
branch
from
40ccb4f
to
a022973
Compare
|
Just tweaked a bit for some changes to the messages (some merged upstream already, some in os-autoinst/openQA#1065 which I am backporting to the Fedora package). |
|
Let's merge, sorry for the delay! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream openQA has added fedmsg messages for comments, so we
should handle them in the processor.
Note: the tests just completely blow up when I try to run them here (on Rawhide), so I threw the necessary bits into a test script to test this. I think it should be OK.