This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
Bz revamp #497
Merged
Bz revamp #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing tests cover only two sample messages that reflect a pre-release state of bugzilla2fedmsg from a long time before it went into production. There's no coverage of the current (fairly messed-up) messages produced by bugzilla2fedmsg 0.3.1 from Bugzilla 5 upstream messages. This rewrites the test suite entirely to cover the various types of real messages we have in production fedmsg/datagrepper, from three slightly different variants of Bugzilla 4 message produced by different states of bugzilla2fedmsg to the various messages we get currently from bugzilla2fedmsg 0.3.1 / Bugzilla 5. It doesn't yet include any fixes for some of the issues that are exposed by these messages, and it doesn't yet cover the somewhat better messages we'll get with the recent fixes for bugzilla2fedmsg. Signed-off-by: Adam Williamson <awilliam@redhat.com>
Due to a bug, bugzilla2fedmsg 0.3.1 sends a bug.update message when a bug is created. We can detect these wrong messages from other data (in the event dict) and generate a correct subtitle for them. Signed-off-by: Adam Williamson <awilliam@redhat.com>
There is no 'weburl' in the bug dict in bugzilla2fedmsg 0.3.1 messages. We could try and get fancy for stg here, but we don't actually seem to have bugzilla messages in stg at all so let's not bother. Signed-off-by: Adam Williamson <awilliam@redhat.com>
In bugzilla2fedmsg 0.3.1+, sometimes these are dicts containing the name and a numeric id, not just a name string. We need to handle that when deriving the 'objects'. Signed-off-by: Adam Williamson <awilliam@redhat.com>
These messages are inherently buggy, so let's make that clear in the subtitle. Ideally bugzilla shouldn't generate these. Signed-off-by: Adam Williamson <awilliam@redhat.com>
|
Ping? Anyone? |
|
@AdamWill Thanks for the fixes, and sorry for the delay! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a rewrite of the tests (to reflect real-world messages better) and several small bugfixes for processing Bugzilla messages as they currently exist (past messages produced by earlier bugzilla2fedmsg versions with Bugzilla 4, and current messages produced by bugzilla2fedmsg 0.3.1 with Bugzilla 5). Note a new release of bugzilla2fedmsg which will fix several big bugs is pending, and I'll have follow-up changes for this processor to cover those.