-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exception arguments and documentation #198
Conversation
Looks good to me, though I expect we may want tests with this? |
261d7af
to
dc8aa78
Compare
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 95.42% 79.9% -15.52%
==========================================
Files 13 13
Lines 1312 1324 +12
Branches 158 160 +2
==========================================
- Hits 1252 1058 -194
- Misses 45 244 +199
- Partials 15 22 +7
Continue to review full report at Codecov.
|
Any idea what's up with the integration test? For me they get also stuck locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, current master also passes CI. Maybe one of the tests is expecting something from one of these exceptions that broke? I don't have time to dig into it today, but I might be able to in the next couple days. |
Signed-off-by: Lukas Holecek <hluk@email.cz>
dc8aa78
to
f3c1648
Compare
Signed-off-by: Lukas Holecek hluk@email.cz