This repository has been archived by the owner on Jul 24, 2018. It is now read-only.
Feature/comma delimited detail value #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def validate_detail_value(ctx, value): | ||
| if ctx.name == 'irc': | ||
| if re.match(irc_regex, value) is None: | ||
| raise ValueError("irc nick must be alphanumeric") |
There was a problem hiding this comment.
irc nick can have _ and [] and - (looking at the nick on #fedora) so we might need to adjust the regex here
There was a problem hiding this comment.
Yeah, {, }, and ^ at least are allowed too.
According to this stackoverflow answer, this beast of a regex should work:
/\A[a-z_\-\[\]\\^{}|][a-z0-9_-[]\^{}|]*\z/i
| def validate_detail_value(ctx, value): | ||
| if ctx.name == 'irc': | ||
| if re.match(irc_regex, value) is None: | ||
| raise ValueError("value must be a valid irc nick") |
There was a problem hiding this comment.
Just an idea: do we want to log what was the suggestion? (a way of finding issues w/ our regex?) or include it in the error message?
|
👍 then :) |
ralphbean
added a commit
that referenced
this pull request
Jan 20, 2014
…l-value Feature/comma delimited detail value
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make it so a user can have more than one email address, more than one irc nick, and most importantly, more than one android device.