This repository has been archived by the owner on Jul 24, 2018. It is now read-only.
Still more defaults tweaking #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to see my own comments.
I tested this pattern with the following script:
```python
import re
hits = [
"Let's wait for @ralph.",
"'@ralph?",
"'@ralph'",
"And then I was like '@ralph won't care.'",
"This is a test for @ralph right?",
"This guy, @ralph, is a guy.",
]
misses = [
"This is a @string",
"@shmalf",
"ralph",
"this is a string with ralph in it."
"butts@ralph.org",
"This is not valid @@ralph",
]
pattern = "[!-~ ]*[^\w@]@ralph[^\w@][!-~ ]*"
for hit in hits:
if re.match(pattern, hit):
print "+ %r" % hit
else:
print "- %r" % hit
for miss in misses:
if re.match(pattern, miss):
print "- %r" % miss
else:
print "+ %r" % miss
```
|
Oh, and that |
| pattern = '[!-~ ]*[^\w@]@%s[^\w@][!-~ ]*' % nick | ||
| filt.add_rule(session, valid_paths, | ||
| "fmn.rules:regex_filter", pattern=pattern) | ||
| pref.add_filter(session, filt, notify=True) |
|
nice 👍 |
ralphbean
added a commit
that referenced
this pull request
Jan 14, 2015
…weaking Still more defaults tweaking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, in 0dadb5d I change/simplify the username filter to just ignore all my
own bodhi activity. No need to see my own comments.
Secondly, in 811054e I add a default filter to catch username mentions.
I tested the pattern with the following script: