This repository has been archived by the owner on Jul 24, 2018. It is now read-only.
Fix processing messages from anitya #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've hotfix this in prod, let's see if that fixes the error I've been seeing |
Messages such as: https://apps.fedoraproject.org/datagrepper/id?is_raw=true&size=extra-large&id=2016-fc73c74c-fc5a-4f65-8ae9-87145bae82e4 Do contain a 'project' key but that key has a value `None` so instead of having the expected `{}`, we end up with a `None` object that has no `.get()` method of course. With this change, we do things in two steps but at least it should work.
pypingou
force-pushed
the
fix_anitya_rules
branch
from
0094ebe
to
ac974eb
Compare
|
🚢 Looks good to me. |
|
Thanks :) |
|
👍 for me too |
|
Thanks as well :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages such as: https://apps.fedoraproject.org/datagrepper/id?is_raw=true&size=extra-large&id=2016-fc73c74c-fc5a-4f65-8ae9-87145bae82e4
Do contain a 'project' key but that key has a value
Noneso insteadof having the expected
{}, we end up with aNoneobject that has no.get()method of course.With this change, we do things in two steps but at least it should work.