Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filters from orther than Generic Rules does not show edit field #40

Closed
voxik opened this issue Jan 13, 2015 · 6 comments · Fixed by fedora-infra/fmn.lib#28
Closed

Filters from orther than Generic Rules does not show edit field #40

voxik opened this issue Jan 13, 2015 · 6 comments · Fixed by fedora-infra/fmn.lib#28

Comments

@voxik
Copy link

voxik commented Jan 13, 2015

I am trying to add "Particular Koschei package groups" filter and it seems there should be possible to edit the groups. At least the description states "You can specify more groups separated by commas." However, there is no edit field to list the groups.

It seems that the edit fields are available just for the "Generic Rules" but unavailable for others. Or am I missing something? Should I combine the filters somehow?
ralphbean added a commit to fedora-infra/fmn.lib that referenced this issue Jan 13, 2015
@ralphbean
Add failing test for fedora-infra/fmn#40.
6a04a1a
@ralphbean ralphbean mentioned this issue Jan 13, 2015
Merged
@ralphbean
Copy link

Thanks for the report @voxik, I totally missed this.

fedora-infra/fmn.lib#28 should fix it.

@voxik
Copy link
Author

voxik commented Jan 14, 2015

Thanks for the fix. Please let me know when it will be available for testing.

@ralphbean
Copy link

Should be today or tomorrow.

@ralphbean
Copy link

@voxik it should be live now if you're available to test it.

@voxik
Copy link
Author

voxik commented Jan 15, 2015

It shows the edit field in the rule list on the right side, but there is still no edit field when the rule is in use in the filter.

@ralphbean
Copy link

It shows the edit field in the rule list on the right side, but there is still no edit field when the rule is in use in the filter.

Oh, that's a general problem with all of the rules. Could you file a separate RFE issue for that?

@voxik voxik mentioned this issue Jan 16, 2015
Closed
jeremycline pushed a commit to jeremycline/fmn that referenced this issue Dec 7, 2016
@ralphbean
Merge pull request fedora-infra#40 from fedora-infra/feature/include-…
884e922 
…anitya

Include anitya messages, which start with org.release-monitoring.*
jeremycline pushed a commit to jeremycline/fmn that referenced this issue Dec 7, 2016
@ralphbean
Merge pull request fedora-infra#40 from fedora-infra/feature/bugfix
219f0c5 
Order of operations matters.
jeremycline pushed a commit to jeremycline/fmn that referenced this issue Dec 7, 2016
@ralphbean
Merge pull request fedora-infra#40 from fedora-infra/feature/invert-c…
41d6b0a 
…allable-hints

Allow callable hints to be inverted.
jeremycline added a commit that referenced this issue Apr 26, 2017
@jeremycline @skrzepto
Move requirements to requirements.txt (#40)
c4f6ffb 
This makes it easy to `pip install -r` or install the dependencies with
Ansible.

This commit also adds the missing dependency on fedmsg

Signed-off-by: Jeremy Cline <jeremy@jcline.org>
jeremycline pushed a commit that referenced this issue Apr 26, 2017
@ralphbean
Merge pull request #40 from msabramo/remove_extra_lines_from_desc_on_…
d99300b 
…PyPI

Remove extra lines from desc on PyPI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix hint decoration. fedora-infra/fmn.lib
2 participants
@voxik @ralphbean