-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add User's Group Membership Details to User Info (Fixes #49) #76
Open
KimFarida
wants to merge
15
commits into
fedora-infra:main
Choose a base branch
from
KimFarida:Issue-49-Fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esolves fedora-infra#51) This commit updates the help text for the user info and user hello commands within the FasHandler class. The descriptions are modified to accurately reflect the information provided by each command: user info: Returns detailed information about a Fedora user, including username, human name, pronouns, creation date, timezone, locale, and GPG key IDs. user hello: Returns a brief introduction of a Fedora user, including username, human name, and pronouns (if available). This clarifies the distinction between the commands and improves the user experience when interacting with the bot. Signed-off-by: [KimFarida] <[farimomoh@gmail.com]>
jeremycline
suggested changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks really good, I think there's one bug from where things weren't indented enough and a few simplifications/style fixes to consider.
@jeremycline @ryanlerch I think we're all good to go now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add User Group Membership Details to Fas Info Command
Description:
This pull request modifies the
FasHandler
class to enhance theuser_info
command by displaying a user's Fedora Accounts group memberships along with their membership types (member or sponsor).PR aims to fix #49
Changes:
The function no longer relies solely on the initial groups list returned by the API.
It iterates through each group name and performs an additional get_group_membership call for sponsors specifically.
_user_info
function is updated to iterate through the user's retrieved groups (a dictionary with group names as keys and membership types as values).Benefits:
Implementation:
The following code snippet demonstrates the changes made to the
_user_info
function:Implemented
get_user_groups
functionTesting:
user_info
command response.This pull request aims to improve the user experience of the
user_info
command by providing more informative group membership details. I appreciate your review and feedback.Below are the screenshots of testcases passed