-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config.py now uses cache file in . directory. #149
Conversation
With our current Fedora Infrastructure, we're using a file-based cache storage we can do the same for our development experience. while memcached being turned off, It was trying to write to a file in / root directory resulting in an error (which works fine in the deployed Fedora-infra). This commit modifies the location of the cache file to create it in the current directory. It would help developers, who are unable to setup memcached and would like to use file based cache for development.
@nasirhm : I can use some help regarding the expected change here. 😅 |
This change works fine for now and you can use it by turning off the memcached setting :). It'll be storing the cache in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @nasirhm.
@@ -48,7 +48,7 @@ | |||
use_memcached = False # Use a memcached store for greater performance | |||
|
|||
# JSON cache store location | |||
json_cache_location = "/var/cache/httpd/mote/cache.json" | |||
json_cache_location = "./cache.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank Youu @t0xic0der for the review, :D |
Discussed in 2020-11-08 sprint meeting. It is suggested, that it is a good idea to get it merged as it provides a better development experience for new developers. cc: @ramyaparimi and @HiraTariq-01 please provide a review on this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go! :D
+1 from me. |
I think, we're good to merge this one, as currently in Fedora Infrastructure, we're using a separate and modified Once the CI runs successfully, we're good to merge it. :D |
I'll make a merge when the CI check completes. 😄 |
Thank you for merging it @t0xic0der |
With our current Fedora Infrastructure, we're using a file-based cache storage
we can do the same for our development experience.
while memcached being turned off,
It was trying to write to a file in / root directory resulting in an error (which works fine in the deployed Fedora-infra).
This commit modifies the location of the cache file to create it in the current directory.
It would help developers, who are unable to setup memcached
and would like to use file based cache for development.
Related Issues: #148 #140
Fixes: #140