This repository has been archived by the owner on Jul 24, 2018. It is now read-only.
Port to openidbaseclient. #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have some kinda of 'unit-tests/integration-tests' script on my machine, that I would like to run against this change before merging it. But from a look at it, looks good to me :) |
pypingou
force-pushed
the
openidbaseclient
branch
from
cdcb2cf
to
26d4da6
Compare
|
The test.py script seems to work with python-fedora 0.7.1, I'll try to remember to ask for this version as minimal in the spec when I do the release. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of technical-debt-fighting week. Removing code duplication. :)
I tested it fairly thoroughly, but there may be a kink or two in there still to debug.