Leaderboard json #147
Merged
Leaderboard json #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -133,6 +133,8 @@ def get_db(request): | |||
| config.add_route('builder', '/builder') | |||
| config.add_route('explore', '/explore') | |||
| config.add_route('leaderboard', '/leaderboard') | |||
| config.add_route('leaderboard_json', '/leaderboard/json') | |||
| #config.add_route('rank_json', '/leaderboard/{id}/json') | |||
There was a problem hiding this comment.
Why is this commented out?
There was a problem hiding this comment.
(answered in IRC - this endpoint will exist soon, I just wanted to note it here since it's related to this change, so I added it at the same time, but commented it.)
|
This is awesome. :) Thanks! |
|
oh, I'm too late. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls out the code that generated JSON for
/user/<id>/jsoninto something that other methods can call, then adds a JSON api that includes that info along with an ordered array of users which forms the leaderboard.