Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please implement __str__ #58

Closed
abompard opened this issue Jun 29, 2023 · 0 comments · Fixed by #60
Closed

Please implement __str__ #58

abompard opened this issue Jun 29, 2023 · 0 comments · Fixed by #60
Labels
good first issue Good for newcomers

Comments

@abompard
Copy link
Member

The default implementation of __str__ just dumps the body of the message, and FMN uses it for the body of email notifications, which produces this:

image

It's not great, just a simple description of the update with a link to the opened bug would be much preferable.
Thanks!
@abompard abompard added the good first issue Good for newcomers label Jun 29, 2023
abompard added a commit to abompard/the-new-hotness-messages that referenced this issue Sep 22, 2023
@abompard
Implement the string representation for hotness.update.bug.file
42f29df 
Fixes: fedora-infra#58
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
@abompard abompard mentioned this issue Sep 22, 2023
Merged
@mergify mergify bot closed this as completed in #60 Sep 22, 2023
mergify bot pushed a commit that referenced this issue Sep 22, 2023
@abompard @mergify
Implement the string representation for hotness.update.bug.file
caa9b2d 
Fixes: #58
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement the string representation for hotness.update.bug.file abompard/the-new-hotness-messages
1 participant
@abompard