Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate name in Anitya causes false warning with every new update seen #59

Closed
penguinpee opened this issue Sep 6, 2023 · 10 comments · Fixed by #61
Closed

Duplicate name in Anitya causes false warning with every new update seen #59

penguinpee opened this issue Sep 6, 2023 · 10 comments · Fixed by #61
Labels
good first issue Good for newcomers

Comments

@penguinpee
Copy link

There are two applications called flare in Anitya. On is a game, of which I am one of the maintainers. The other is a Signal (chat) client.

Whenever the Signal client has a new release, I'm getting the following:

Id: e7616955-af4a-4f21-a6a3-8db4fcea6b5e
Topic: org.fedoraproject.prod.hotness.update.drop
Headers: {
    "fedora_messaging_rpm_flare": true,
    "fedora_messaging_schema": "hotness.update.drop",
    "fedora_messaging_severity": 20,
    "fedora_messaging_user_None": true,
    "sent-at": "2023-08-28T12:41:17+00:00"
}
Body: {
    "reason": "anitya",
    "trigger": {
        "msg": {
            "distro": null,
            "message": {
                "agent": "anitya",
                "ecosystem": ["https://gitlab.com/schmiddi-on-mobile/flare"](https://gitlab.com/schmiddi-on-mobile/flare),
                "old_version": "0.9.3",
                "packages": [
                    {
                        "distro": "Alpine",
                        "package_name": "flare"
                    }
                ],
                "project": {
                    "backend": "GitLab",
                    "created_on": 1677870644.0,
                    "ecosystem": ["https://gitlab.com/schmiddi-on-mobile/flare"](https://gitlab.com/schmiddi-on-mobile/flare),
                    "homepage": ["https://gitlab.com/schmiddi-on-mobile/flare"](https://gitlab.com/schmiddi-on-mobile/flare),
                    "id": 328536,
                    "name": "flare",
                    "regex": null,
                    "stable_versions": [
                        "0.10.0",
                        "0.9.3",
                        "0.9.2",
                        "0.9.1",
                        "0.9.0",
                        "0.8.2",
                        "0.8.1",
                        "0.8.0",
                        "0.7.2",
                        "0.7.1",
                        "0.7.0",
                        "0.6.0",
                        "0.5.7",
                        "0.5.6",
                        "0.5.5",
                        "0.5.4",
                        "0.5.3",
                        "0.5.2",
                        "0.5.1",
                        "0.5.0",
                        "0.4.1",
                        "0.4.0",
                        "0.3.3",
                        "0.3.2",
                        "0.3.1",
                        "0.3.0",
                        "0.2.1",
                        "0.2.0",
                        "0.1.5",
                        "0.1.4",
                        "0.1.3"
                    ],
                    "updated_on": 1693226477.0,
                    "version": "0.10.0",
                    "version_url": ["https://gitlab.com/schmiddi-on-mobile/flare"](https://gitlab.com/schmiddi-on-mobile/flare),
                    "versions": [
                        "0.10.0",
                        "0.9.3",
                        "0.9.2",
                        "0.9.1",
                        "0.9.0",
                        "0.9.0-beta.1",
                        "0.8.2",
                        "0.8.2-beta.1",
                        "0.8.1",
                        "0.8.0",
                        "0.8.0-beta.1",
                        "0.7.2",
                        "0.7.1",
                        "0.7.0",
                        "0.7.0-beta.1",
                        "0.6.0",
                        "0.5.7",
                        "0.5.6",
                        "0.5.5",
                        "0.5.4",
                        "0.5.3",
                        "0.5.2",
                        "0.5.1",
                        "0.5.0",
                        "0.4.1",
                        "0.4.0",
                        "0.3.3",
                        "0.3.2",
                        "0.3.1",
                        "0.3.0",
                        "0.2.1",
                        "0.2.0",
                        "0.1.5",
                        "0.1.4",
                        "0.1.3"
                    ]
                },
                "stable_versions": [
                    "0.10.0",
                    "0.9.3",
                    "0.9.2",
                    "0.9.1",
                    "0.9.0",
                    "0.8.2",
                    "0.8.1",
                    "0.8.0",
                    "0.7.2",
                    "0.7.1",
                    "0.7.0",
                    "0.6.0",
                    "0.5.7",
                    "0.5.6",
                    "0.5.5",
                    "0.5.4",
                    "0.5.3",
                    "0.5.2",
                    "0.5.1",
                    "0.5.0",
                    "0.4.1",
                    "0.4.0",
                    "0.3.3",
                    "0.3.2",
                    "0.3.1",
                    "0.3.0",
                    "0.2.1",
                    "0.2.0",
                    "0.1.5",
                    "0.1.4",
                    "0.1.3"
                ],
                "upstream_versions": [
                    "0.10.0"
                ],
                "versions": [
                    "0.10.0",
                    "0.9.3",
                    "0.9.2",
                    "0.9.1",
                    "0.9.0",
                    "0.9.0-beta.1",
                    "0.8.2",
                    "0.8.2-beta.1",
                    "0.8.1",
                    "0.8.0",
                    "0.8.0-beta.1",
                    "0.7.2",
                    "0.7.1",
                    "0.7.0",
                    "0.7.0-beta.1",
                    "0.6.0",
                    "0.5.7",
                    "0.5.6",
                    "0.5.5",
                    "0.5.4",
                    "0.5.3",
                    "0.5.2",
                    "0.5.1",
                    "0.5.0",
                    "0.4.1",
                    "0.4.0",
                    "0.3.3",
                    "0.3.2",
                    "0.3.1",
                    "0.3.0",
                    "0.2.1",
                    "0.2.0",
                    "0.1.5",
                    "0.1.4",
                    "0.1.3"
                ]
            },
            "project": {
                "backend": "GitLab",
                "created_on": 1677870644.0,
                "ecosystem": ["https://gitlab.com/schmiddi-on-mobile/flare"](https://gitlab.com/schmiddi-on-mobile/flare),
                "homepage": ["https://gitlab.com/schmiddi-on-mobile/flare"](https://gitlab.com/schmiddi-on-mobile/flare),
                "id": 328536,
                "name": "flare",
                "regex": null,
                "stable_versions": [
                    "0.10.0",
                    "0.9.3",
                    "0.9.2",
                    "0.9.1",
                    "0.9.0",
                    "0.8.2",
                    "0.8.1",
                    "0.8.0",
                    "0.7.2",
                    "0.7.1",
                    "0.7.0",
                    "0.6.0",
                    "0.5.7",
                    "0.5.6",
                    "0.5.5",
                    "0.5.4",
                    "0.5.3",
                    "0.5.2",
                    "0.5.1",
                    "0.5.0",
                    "0.4.1",
                    "0.4.0",
                    "0.3.3",
                    "0.3.2",
                    "0.3.1",
                    "0.3.0",
                    "0.2.1",
                    "0.2.0",
                    "0.1.5",
                    "0.1.4",
                    "0.1.3"
                ],
                "updated_on": 1693226477.0,
                "version": "0.10.0",
                "version_url": ["https://gitlab.com/schmiddi-on-mobile/flare"](https://gitlab.com/schmiddi-on-mobile/flare),
                "versions": [
                    "0.10.0",
                    "0.9.3",
                    "0.9.2",
                    "0.9.1",
                    "0.9.0",
                    "0.9.0-beta.1",
                    "0.8.2",
                    "0.8.2-beta.1",
                    "0.8.1",
                    "0.8.0",
                    "0.8.0-beta.1",
                    "0.7.2",
                    "0.7.1",
                    "0.7.0",
                    "0.7.0-beta.1",
                    "0.6.0",
                    "0.5.7",
                    "0.5.6",
                    "0.5.5",
                    "0.5.4",
                    "0.5.3",
                    "0.5.2",
                    "0.5.1",
                    "0.5.0",
                    "0.4.1",
                    "0.4.0",
                    "0.3.3",
                    "0.3.2",
                    "0.3.1",
                    "0.3.0",
                    "0.2.1",
                    "0.2.0",
                    "0.1.5",
                    "0.1.4",
                    "0.1.3"
                ]
            }
        },
        "topic": "org.release-monitoring.prod.anitya.project.version.update.v2"
    }
}

There is no mapping for the other flare into Fedora. So, how come it sends me these reminders?
@abompard
Copy link
Member

abompard commented Sep 7, 2023

Thanks for reporting! Indeed, it may be that the Anitya schemas build the packages attribute regardless of which distribution the package is linked for. This is a bug in Anitya's message schemas, I'll transfer it there (if I can)

@abompard abompard transferred this issue from fedora-infra/fmn Sep 7, 2023
@abompard abompard added the good first issue Good for newcomers label Sep 7, 2023
@penguinpee
Copy link
Author

Well, that's where I reported it first: fedora-infra/anitya#1664

Happy ping-pong! 😉

@Zlopez
Copy link
Collaborator

Zlopez commented Sep 7, 2023 •
edited
Loading

@abompard What FMN expects in packages? Anitya has mappings for multiple distributions, but it's always mentioned in the packages list in JSON.
See

"packages": 
[
   {
      "distro": "Alpine",
      "package_name": "flare"
   }
],

@abompard
Copy link
Member

abompard commented Sep 7, 2023 •
edited
Loading

Oh, my bad, it should actually be filed on the-new-hotness-messages. I'll transfer it yet again.

FMN reads the .packages property, which is defined in the the-new-hotness schema not by reading the dict and only keeping the Fedora distro mappings, but by looking at the project value.

@abompard abompard transferred this issue from fedora-infra/anitya-messages Sep 7, 2023
@Zlopez
Copy link
Collaborator

Zlopez commented Sep 7, 2023

That would be easy to do :-)

abompard added a commit to abompard/the-new-hotness-messages that referenced this issue Sep 22, 2023
@abompard
Don't return packages when we don't know how they are named in Fedora
ef8eb85 
Fixes: fedora-infra#59
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
@abompard abompard mentioned this issue Sep 22, 2023
Merged
@mergify mergify bot closed this as completed in #61 Sep 22, 2023
mergify bot pushed a commit that referenced this issue Sep 22, 2023
@abompard @mergify
Don't return packages when we don't know how they are named in Fedora
83869a1 
Fixes: #59
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
@penguinpee
Copy link
Author

Has this been deployed yet to production? If so, it is not working. I received another notification today for the other package called flare as described above.

@Zlopez
Copy link
Collaborator

Zlopez commented Nov 20, 2023

Could you link the bugzilla ticket here?

@Zlopez
Copy link
Collaborator

Zlopez commented Nov 20, 2023

Looking at the deployment, this is not deployed yet in the-new-hotness

@Zlopez
Copy link
Collaborator

Zlopez commented Nov 20, 2023

I add this to my TODO list

@penguinpee
Copy link
Author

Could you link the bugzilla ticket here?

There is none, afaik. If you're talking package update ticket, there wouldn't be one, since there's no package in Fedora to link the update to.

Looking at the deployment, this is not deployed yet in the-new-hotness
I add this to my TODO list

Excellent. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@abompard @Zlopez @penguinpee