Add parsing functions that return failure information #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgallagher
added
enhancement
SEMVER_MINOR
Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
New functions: * Modulemd.objects_from_file_ext() * Modulemd.objects_from_string_ext() * Modulemd.objects_from_stream_ext() * Modulemd.Defaults.new_from_file_ext() * Modulemd.Defaults.new_from_string_ext() * Modulemd.Defaults.new_from_stream_ext() * Modulemd.Module.new_from_file_ext() * Modulemd.Module.new_from_string_ext() * Modulemd.Module.new_from_stream_ext() These functions will return an array of Modulemd.Subdocument objects that includes a GError explaining the failure as well as the YAML string that failed (or at least as much of it as libyaml was able to read). Fixes: fedora-modularity#47 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
sgallagher
force-pushed
the
parser-with-error-reporting
branch
from
fe141c5
to
bfae697
Compare
Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
sgallagher
force-pushed
the
parser-with-error-reporting
branch
from
b7f536d
to
9ac33fb
Compare
|
@sgallagher I think the patch is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Objects:
New functions:
These functions will return an array of Modulemd.Subdocument
objects that includes a GError explaining the failure as well as
the YAML string that failed (or at least as much of it as libyaml
was able to read).
Fixes: #47
cc @dmach @hanzz
Signed-off-by: Stephen Gallagher sgallagh@redhat.com