Inline argument clinic code and remove private Python API #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroncok
reviewed
Apr 26, 2024
hroncok
force-pushed
the
remove_argument_clinic
branch
from
3ba3275
to
36500c6
Compare
|
I split the change here into 2 separate commits. |
Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Karolina Surma <ksurma@redhat.com>
We assume they are available on the system. Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Karolina Surma <ksurma@redhat.com>
hroncok
force-pushed
the
remove_argument_clinic
branch
from
36500c6
to
77023b9
Compare
hroncok
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the HAVE_CRYPT_R ifdef and HAVE_CRYPT_H ifdef; we assume they are available on the system.