[specfile] drop dependency on /etc/system-release completely #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keszybz
previously approved these changes
Oct 30, 2017
deekej
dismissed
keszybz’s stale review
I have added the Conflicts for older versions of fedora-release. Please, check again. Thanks! :)
keszybz
previously requested changes
Oct 30, 2017
There was a problem hiding this comment.
Very dangerous, see https://bugzilla.redhat.com/show_bug.cgi?id=1493479#c19.
Agreed. I have reverted the change, and added the |
This will allow users to unistall 'system-release' or 'fedora-release' package, thus allowing de-branding of Fedora if needed. For more info: https://bugzilla.redhat.com/show_bug.cgi?id=1493479
deekej
changed the title
keszybz
approved these changes
Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the
fedora-releasewill be still installed by default together with initscripts, but initscripts will no longer block users from unistallingfedora-release, if they require so.IOW, the Fedora branding will not be forced by initscripts any more.