Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

[RAINCATCH-1182] Fix loglevel compile issue #106

Merged
merged 2 commits into from Aug 30, 2017
Merged

Conversation

paolobueno
Copy link
Contributor

Motivation

Fix compilation issues from hybrid hoisting and non-hoisting bootstrapping via using the core and angularjs repos together.

Description

Use the loglevel library untyped, copy over relevant enum.

This should fix the compilation issues without changing the logger's public library.

@paolobueno
Copy link
Contributor Author

To verify:

  • Run lerna bootstrap from core/ linked inside the angularjs repo
  • Run lerna bootstrap from the angularjs repo above in the filesystem structure
  • Run lerna run build from the angularjs repo, it should also compile the logger module correctly

@coveralls
Copy link

coveralls commented Aug 30, 2017

Coverage Status

Changes Unknown when pulling c06efe7 on RAINCATCH-1182 into ** on master**.

@wtrocki
Copy link
Member

wtrocki commented Aug 30, 2017

Verified

@paolobueno paolobueno merged commit 321414b into master Aug 30, 2017
@paolobueno paolobueno deleted the RAINCATCH-1182 branch August 30, 2017 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants