-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
Changes Unknown when pulling 83db279 on RAINCATCH-1351 into ** on file-storage-support**. |
cloud/file-store/src/FileRoutes.ts
Outdated
next(); | ||
}; | ||
|
||
router.route('/:filename/binary').post(binaryUploadInitMiddleware, fileService.mutlerMiddleware, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we need these separate endpoints? I think we can use http headers instead.
Seems like multer already only works on top of multipart/form-data
, so for base64 we could go with Content-Type: application/octet-stream
and maybe Content-Transfer-Encoding: base4
, or even Content-Type: application/base64
See: https://www.w3.org/Protocols/rfc1341/5_Content-Transfer-Encoding.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome comment. Fully agree. Going to merge them together!
@JameelB - I pushed changes to origin by routine :) |
Changes Unknown when pulling e1f5822 on RAINCATCH-1351 into ** on file-storage-support**. |
1 similar comment
Changes Unknown when pulling e1f5822 on RAINCATCH-1351 into ** on file-storage-support**. |
Changes Unknown when pulling 53f72ea on RAINCATCH-1351 into ** on file-storage-support**. |
* RAINCATCH-1351 - File Server (#156) * WIP file sync client (#159) * Use fetch api from filestore-client (#163) * Use fetch to upload data * Use fetch for download * Improve upload calls * [RAINCATCH-1350] Add camera package to support camera step (#164) * Move camera class from step * adjust package versions * Add filestore dependency * Remove data uri responsibility from file-upload * Add index for exporting public interface * Add used deps * Add FileEntry interface, use updload from camera module * Add todo item * Fix typescript compilation errors (#166) * Fix initialization callback order (#167) * Minor tweaks (#168) * Minor tweaks * Refactoring * Temporary untested changes * Change filesystem query to resolveLocalFileSystemUrl (#170) * Http file support * fix file-store api (#174) * Add interfaces to file manager (#173) * Split files for interfaces, add httpclient interface * Use interfaces from relevant code * Fix type typo * Add extra metadata to post request (#175) * Remove extra route param * Delete subproject * Include extra metadata in post data * [RAINCATCH-1389] Support base64 upload (#176) * Fix sending data from browser as data-uri * Accept base64 type for uploads * Remove base64/ * Move Id generation to client (#177) * Remove id generation from server * Move file after upload * Remove extra debugger call * README for filestorage module (#178) * Add initial readme content * Add more jsdocs * Ignore vscode extra config * Add Readme and JSDocs to the filestore-client (#179) * Add jsdocs * add readme * Update to master (#182) * Fix types error for api-controller and demoDataSetup (#169) * fix types error for api-controller and demoDataSetup * handle undefined connectionPromise * Fix compilation error * Pre release (#183) * Add public access to package.json for new packages * Pre-release publishing * [RAINCATCH-1388] Filestore tests (#180) * Start refactoring for tests * Add some tests for filestore * Add tests for writeStreamToFile * Finish tests for fileService * Lower coverage reqs * Rename storage class to match filename * Add string type for createTemporaryStorageFolder * Add first tests for gridfs storage * Add tests for gridfs * Update jsdocs * Update package version to pre-release one * update dependencies to match hoisted versions * Fix hanging test * [RAINCATCH-1386][WIP] Add unit tests for FileStore Client (#181) * add tests for fileQueue * add fileManager tests * [RAINCATCH 1387] Tests for Camera (#184) * Add tests for buildCameraOptions * Add some mocks * Update versions to match hoisted * Add tests for capture() * Fix linting and remove coverage check on unfinished tests * Fix file queue tests * Update dependencies * Add snyk exception to s3 * Add generics to promisify call to avoid compilation errors * Fix promisify * Change version of filestore
Motivation
WIP work for file server.
Requires some refactoring to fit to typescript model.
Progress