This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
File storage support feature #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtrocki
changed the title
wtrocki
force-pushed
the
file-storage-support
branch
from
a3dd00c
to
95e7212
Compare
* Use fetch to upload data * Use fetch for download * Improve upload calls
* Move camera class from step * adjust package versions * Add filestore dependency * Remove data uri responsibility from file-upload * Add index for exporting public interface * Add used deps * Add FileEntry interface, use updload from camera module * Add todo item
* Minor tweaks * Refactoring * Temporary untested changes
* Split files for interfaces, add httpclient interface * Use interfaces from relevant code * Fix type typo
* Remove extra route param * Delete subproject * Include extra metadata in post data
* Fix sending data from browser as data-uri * Accept base64 type for uploads * Remove base64/
* Remove id generation from server * Move file after upload * Remove extra debugger call
* Add initial readme content * Add more jsdocs * Ignore vscode extra config
* Add jsdocs * add readme
* Fix types error for api-controller and demoDataSetup (#169) * fix types error for api-controller and demoDataSetup * handle undefined connectionPromise * Fix compilation error
* Add public access to package.json for new packages * Pre-release publishing
* Start refactoring for tests * Add some tests for filestore * Add tests for writeStreamToFile * Finish tests for fileService * Lower coverage reqs * Rename storage class to match filename * Add string type for createTemporaryStorageFolder * Add first tests for gridfs storage * Add tests for gridfs * Update jsdocs * Update package version to pre-release one * update dependencies to match hoisted versions * Fix hanging test
* add tests for fileQueue * add fileManager tests
* Add tests for buildCameraOptions * Add some mocks * Update versions to match hoisted * Add tests for capture() * Fix linting and remove coverage check on unfinished tests * Fix file queue tests
wtrocki
force-pushed
the
file-storage-support
branch
from
20546e2
to
5555c17
Compare
|
Changes Unknown when pulling 5555c17 on file-storage-support into ** on master**. |
|
Changes Unknown when pulling d22e76f on file-storage-support into ** on master**. |
|
It looks like that we still getting error: |
austincunningham
approved these changes
Nov 20, 2017
|
@paolobueno Can I just rebase and merge this? It's required to fix angularjs build. |
|
@paolobueno I looks like we sending back the local uri to server. Curious if that is needed?
I noticed that download (sync changes from the server) is not included in the demo. We demoing i only for the portal (using different http api). I think that it's ok to go without this option, but worth to mention that we support sync from server. Is that ok? Going to test it to make sure it works. |
|
Download works fine! I couldn't really figure out how to replicate it in the standard step so we going to leave that without example. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See: https://issues.jboss.org/browse/RAINCATCH-1349