Fix ow #86
Closed
Fix ow #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion instead of a generice, checked, exception
initialized properly instead of a RuntimeException.
…d pass them in the call back. Declaring "throws exception" is unnecessary.
…xception. The throws declaration is not needed anymore
…ed and swallowed. Now the failure callback is called with the exception that happened during processing.
…lures should all be passed to the callback instead and the declaration was obsolete.
The http client should catch all exceptions and return them on the callback failure method. Additionally throws FHNotReadyExcption was declared.
FHRemote and friends handle excpetions more correctly now so the callback failure has to be checked instead of catching an exception.
…pdates were not being reported
…pdates were not being reported
|
@danielpassos You checked this before but I just want to make sure it is ok. |
|
Landed at 775dbc3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The V3.8.0 work that got force pushed over.