Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ow #86

Closed
wants to merge 29 commits into from
Closed

Fix ow #86

wants to merge 29 commits into from

Commits on Jan 13, 2016

  1. Changing the constructor exception to throw UnsupportedOperationExcep… 

    …tion instead of a generice, checked, exception
    @secondsun
    secondsun committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    98a3ad9 View commit details
    Browse the repository at this point in the history

  2. Throwing IllegalArgumentException when a user tries to use an unsuppo… 

    …rted HTTP Method
    @secondsun
    secondsun committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    cc04c88 View commit details
    Browse the repository at this point in the history

  3. Narrowing the thrown exception type and also updating JavaDoc

    @secondsun
    secondsun committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    115d5b4 View commit details
    Browse the repository at this point in the history

  4. getInstance should throw an IllegalStateException if it is not 

    initialized properly instead of a RuntimeException.
    @secondsun
    secondsun committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    869414c View commit details
    Browse the repository at this point in the history

  5. FHHttpClient's sync and async clients should catch errors themself an… 

    …d pass them in the call back. Declaring "throws exception" is unnecessary.
    @secondsun
    secondsun committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    fbcc961 View commit details
    Browse the repository at this point in the history

  6. getDefaultParamsAsHeaders now throws a runtime instead of a checked E… 

    …xception. The throws declaration is not needed anymore
    @secondsun
    secondsun committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    263034c View commit details
    Browse the repository at this point in the history

  7. Removing the throws declaration from FHAct and its implementations

    @secondsun
    secondsun committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    b26365c View commit details
    Browse the repository at this point in the history

  8. Removing the throws declaration from FHRemote and its implementations

    @secondsun
    secondsun committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    f6ad483 View commit details
    Browse the repository at this point in the history

  9. Previously any exception thrown in the Auth response handler was logg… 

    …ed and swallowed.

Now the failure callback is called with the exception that happened during processing.
    @secondsun
    secondsun committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    c60a84a View commit details
    Browse the repository at this point in the history

  10. removing the throws declaration on callRemote. The Exceptions and fai… 

    …lures should all be passed to the callback instead and the declaration was obsolete.
    @secondsun
    secondsun committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    d72b200 View commit details
    Browse the repository at this point in the history

  11. Removing throws Exception Declaration where FhNotReadyException is mo… 

    …re appropriate
    @secondsun
    secondsun committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    688a000 View commit details
    Browse the repository at this point in the history

  12. removing throws exception in sdk2.FHAct

    @secondsun
    secondsun committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    1c78595 View commit details
    Browse the repository at this point in the history

  13. removing throws exception in sdk2.FHRemote

    @secondsun
    secondsun committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    823010f View commit details
    Browse the repository at this point in the history

  14. Replacing throws Exception with a more descriptive exception.

    @secondsun
    secondsun committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    3642717 View commit details
    Browse the repository at this point in the history

  15. Replacing throws Exception declaration. 

    The http client should catch all exceptions and return them on the callback failure method.  Additionally throws FHNotReadyExcption was declared.
    @secondsun
    secondsun committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    88cf9f4 View commit details
    Browse the repository at this point in the history

  16. Removing the need for exceptions by letting the type system do the he… 

    …avy lifting.
    @secondsun
    secondsun committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    6e15ad0 View commit details
    Browse the repository at this point in the history

  17. Narrowing exceptions

    @secondsun
    secondsun committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    631f4e5 View commit details
    Browse the repository at this point in the history

  18. Fixing broken tests. 

    FHRemote and friends handle excpetions more correctly now so the callback failure has to be checked instead of catching an exception.
    @secondsun
    secondsun committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    b28472e View commit details
    Browse the repository at this point in the history

  19. Merge branch 'pr/79' into FH-v3.8.0

    @danielpassos
    danielpassos committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    4adbc62 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2016

  1. Removing an unused local field and fixing a bug where failed remote u… 

    …pdates were not being reported
    @secondsun
    secondsun committed Jan 26, 2016
    Configuration menu
    Copy the full SHA
    8a21b02 View commit details
    Browse the repository at this point in the history

  2. Adding exception messages

    @secondsun
    secondsun committed Jan 26, 2016
    Configuration menu
    Copy the full SHA
    7a96c3d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'pr/84' into FH-v3.8.0

    @danielpassos
    danielpassos committed Jan 26, 2016
    Configuration menu
    Copy the full SHA
    5437e80 View commit details
    Browse the repository at this point in the history

  4. Removing an unused local field and fixing a bug where failed remote u… 

    …pdates were not being reported
    @secondsun @danielpassos
    secondsun authored and danielpassos committed Jan 26, 2016
    Configuration menu
    Copy the full SHA
    c7d1538 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'pr/83' into FH-v3.8.0

    @danielpassos
    danielpassos committed Jan 26, 2016
    Configuration menu
    Copy the full SHA
    cf8c478 View commit details
    Browse the repository at this point in the history

  6. Add travis-ci matrix test

    @danielpassos
    danielpassos committed Jan 26, 2016
    Configuration menu
    Copy the full SHA
    962cd1b View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2016

  1. Merge branch '79'

    @secondsun
    secondsun committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    257223a View commit details
    Browse the repository at this point in the history

  2. Merge commit 'refs/pull/83/head' of github.com:feedhenry/fh-android-sdk

    @secondsun
    secondsun committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    932013e View commit details
    Browse the repository at this point in the history

  3. Merge commit 'refs/pull/84/head' of github.com:feedhenry/fh-android-sdk

    @secondsun
    secondsun committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    cb12b66 View commit details
    Browse the repository at this point in the history

  4. Merge commit 'refs/pull/85/head' of github.com:feedhenry/fh-android-sdk

    @secondsun
    secondsun committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    626c754 View commit details
    Browse the repository at this point in the history