Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DockerFile for integration tests. #12

Merged
merged 1 commit into from
Jan 16, 2017

Conversation

sedroche
Copy link
Contributor

Motivation

fh-dataman integration tests needs a specific version of mongodb to perform tests against. Adding a docker file as a convenience for running tests.

  • updated README

Copy link
Contributor

@pb82 pb82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,10 @@
use admin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add semicolons at the end of both commands.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, will update

@sedroche sedroche merged commit b13b18b into master Jan 16, 2017
@sedroche sedroche deleted the docker-for-integration-tests branch January 16, 2017 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants