Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhmap 1157 repeating sections #18

Merged
merged 44 commits into from
Nov 10, 2017
Merged

Conversation

witmicko
Copy link
Contributor

@witmicko witmicko commented Aug 23, 2017

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 75.039% when pulling 71b5dc9 on RHMAP-1157-Repeating_Sections into 8160ab2 on master.

});

for (var i = 0; i < field.fieldOptions.definition.maxRepeat; i++) {
_.each(fieldsInThisSection, function(fieldInThisSection) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INFO Define this function outside of a loop. rule

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 75.013% when pulling 923389b on RHMAP-1157-Repeating_Sections into 8160ab2 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 75.013% when pulling 80e1481 on RHMAP-1157-Repeating_Sections into 8160ab2 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 75.013% when pulling 6c1c229 on RHMAP-1157-Repeating_Sections into 8160ab2 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 75.018% when pulling 6c1c229 on RHMAP-1157-Repeating_Sections into 8160ab2 on master.

@fh-qube
Copy link

fh-qube commented Sep 6, 2017

SonarQube analysis reported 1 issue:

  • INFO 1 info

Watch the comments in this conversation to review them.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 75.018% when pulling 6b3a57f on RHMAP-1157-Repeating_Sections into 8160ab2 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 75.018% when pulling 6b3a57f on RHMAP-1157-Repeating_Sections into 8160ab2 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 74.935% when pulling c191a87 on RHMAP-1157-Repeating_Sections into 57e7445 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 74.956% when pulling be8661c on RHMAP-1157-Repeating_Sections into 57e7445 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 74.956% when pulling a4e390d on RHMAP-1157-Repeating_Sections into 57e7445 on master.

@coveralls
Copy link

coveralls commented Nov 10, 2017

Coverage Status

Coverage decreased (-0.9%) to 74.945% when pulling 95e7a34 on RHMAP-1157-Repeating_Sections into 57e7445 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 74.956% when pulling 981e267 on RHMAP-1157-Repeating_Sections into 57e7445 on master.

@jhellar jhellar self-requested a review November 10, 2017 10:27
Copy link
Member

@jhellar jhellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 74.945% when pulling a1868ea on RHMAP-1157-Repeating_Sections into 57e7445 on master.

@witmicko witmicko merged commit 641baa0 into master Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants