Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Added support for coveralls.io #22

Merged
merged 1 commit into from
Oct 20, 2016
Merged

Conversation

jhellar
Copy link
Member

@jhellar jhellar commented Oct 19, 2016

Motivation

https://issues.jboss.org/browse/FH-2619
Add code coverage status with coveralls.io.

Change

Modified travis config to generate also code coverage and send that to coveralls.io.
Added badge to README.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 55d391a on jhellar:FH-2619 into * on feedhenry:master*.

- brew install macmade/tap/xcode-coveralls

script:
- xctool -workspace FeedHenry.xcworkspace -scheme FeedHenry build test -sdk iphonesimulator GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=YES GCC_GENERATE_TEST_COVERAGE_FILES=YES
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhellar With Xcode 8 and Swift3 update coming very soon, xctool is not supported anymore (see: facebookarchive/xctool#704) could you use xcodebuild instead pls

@corinnekrych
Copy link
Contributor

@jhellar Looking at the detailled coverage report https://coveralls.io/builds/8406958
I don't see any of the Swift files. Only the Objective-C has been instrumented.
for the fh-ios-swift-sdk only the sync code has been left in Objective-C, all the other part, ie: cloud call, oauth, push are in swift.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 85ce386 on jhellar:FH-2619 into * on feedhenry:master*.

@jhellar
Copy link
Member Author

jhellar commented Oct 20, 2016

@corinnekrych should be fixed. I managed to get this work with slather.

@corinnekrych
Copy link
Contributor

@jhellar why do we have files like:
/../../../../../Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk/usr/include/sys/_types.h
included in the coverage report?

@jhellar
Copy link
Member Author

jhellar commented Oct 20, 2016

@corinnekrych I did not notice and I'm not sure, thought that these should be ignored because of "source_directory: FeedHenry" line in .slather.yml. I will look at this.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0a407ae on jhellar:FH-2619 into * on feedhenry:master*.

@jhellar
Copy link
Member Author

jhellar commented Oct 20, 2016

@corinnekrych should be fixed now.

@corinnekrych
Copy link
Contributor

+1
thanks!!! @jhellar
🌹 🌹

@corinnekrych corinnekrych merged commit 1193fc4 into feedhenry:master Oct 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants