-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing of datetime produces debug log as warning #395
Comments
This has been released in https://github.com/feedjira/feedjira/releases/tag/v2.1.3 |
Seems there was a regression and in version |
Fix #395 (again). There are a couple of places we log out failures to parse dates. This updates the *other* one to be `debug` log level.
Fix #395 (again). There are a couple of places we log out failures to parse dates. This updates the *other* one to be `debug` log level.
@Ben-Fenner can you give version 3.2.3 a try? |
Sorry, version I went to go find it to give you a link to the code just now, but it looks like it's been fixed. And looking at the file history, it seems you did so yourself about 3 days ago. 👍 336b658 I see now you're hoping I can test that out. Sorry I can't test because I'm on Ruby For those who find this issue in the future and need a work-around like I did. We added a Rails initializer that changes the log level to ERROR.
# Feedjira's logging for datetime parse issues is set to WARN, and so is the resulting backtrace output, when both (or
# at least the backtrace) should be set to DEBUG. This was a problem in `2.1.2` and was fixed in `2.1.3` but returned as
# a regression some time later and the version we're on now (`3.1.1`) is misbehaving again. So we set the log level here
# abnormally high to avoid that situation.
#
# Refs:
# https://github.com/feedjira/feedjira/issues/397
# https://github.com/feedjira/feedjira/issues/395
# https://github.com/feedjira/feedjira/blob/v3.1.1/lib/feedjira/configuration.rb
# https://stackoverflow.com/questions/2031163/when-to-use-the-different-log-levels
#
# TODO: It looks like version 3.2.3 has the fix for this, so upgrade when possible.
Feedjira.configure do |config|
config.logger.level = Logger::ERROR
end |
When parsing a datetime that isn't supported and logger is set to log level "WARN" the debug output aka backtrace is logged with severity WARN instead of DEBUG.
The text was updated successfully, but these errors were encountered: