use vcr to stub network requests #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 danger |
there are three tests in feed_spec that require network to pass. PR feedjira#297 fixes the immediate issue by making the test general enough to pass when the response from the server changes somewhat. PR feedjira#300 fixes the network issue, but uses specific stubs. I would say this method is no better or worse than this one, however it does require knowing that you are stubbing the request and manually keeping responses up to date. This method acts the most like actually hitting the network and will work on an airplane.
HParker
force-pushed
the
stub-network-tests
branch
from
da5063e
to
5c26c43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are three tests in feed_spec that require network to pass.
PR #297 fixes the immediate issue by making the test general enough to
pass when the response from the server changes somewhat.
PR #300 fixes the network issue, but uses specific stubs. I would say
this method is no better or worse than this one, however it does require
knowing that you are stubbing the request and manually keeping responses
up to date.
This method acts the most like actually hitting the network and will
work on an airplane.