Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use vcr to stub network requests #325

Merged
merged 1 commit into from Nov 9, 2016
Merged

use vcr to stub network requests #325

merged 1 commit into from Nov 9, 2016

Commits on Nov 9, 2016

  1. Use vcr to stub network requests 

    there are three tests in feed_spec that require network to pass.

PR feedjira#297 fixes the immediate issue by making the test general enough to
pass when the response from the server changes somewhat.

PR feedjira#300 fixes the network issue, but uses specific stubs. I would say
this method is no better or worse than this one, however it does require
knowing that you are stubbing the request and manually keeping responses
up to date.

This method acts the most like actually hitting the network and will
work on an airplane.
    @HParker
    HParker committed Nov 9, 2016
    Configuration menu
    Copy the full SHA
    5c26c43 View commit details
    Browse the repository at this point in the history