Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1946 fix dll loader for mor plugins if so not present #1948

Merged
merged 11 commits into from
Sep 27, 2022
Merged

1946 fix dll loader for mor plugins if so not present #1948

merged 11 commits into from
Sep 27, 2022

Conversation

prudhomm
Copy link
Member

@prudhomm prudhomm commented Sep 23, 2022 •
edited

  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes?
  • Have you successfully run the Feel++ testsuite with your changes locally?
  • Have you written Doxygen comments in your contribution ?

now plugins have only .so extension (e.g. not .so.x or .so.x.y on linux ) and they go in their own directory. the option --plugindir for feelpp_mor_online_run should not be needed anymore

/cc @feelpp/mbda

@prudhomm
add support for plugindir() casesdir() toolboxcasesdir() Fix dll load…
eaea74d 
…er for mor plugins if .so not present #1946
@prudhomm
use plugindir() for mor plugins
404789e 
Fix dll loader for mor plugins if .so not present #1946
@prudhomm prudhomm added env: cmake build environment cmake module:crb labels Sep 23, 2022
@prudhomm prudhomm added this to the v110 milestone Sep 23, 2022
@prudhomm prudhomm self-assigned this Sep 23, 2022
@prudhomm prudhomm linked an issue Sep 23, 2022 that may be closed by this pull request
Fix dll loader for mor plugins if .so not present #1946
Closed
vincentchabannes
vincentchabannes reviewed Sep 23, 2022
View reviewed changes
Copy link
Member

@vincentchabannes vincentchabannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other examples that use plugin in feelpp/mor/examples/ :

  • BenchmarkGrepl
  • heat3d
  • linearelasticity3d
  • thermalbuilding

@prudhomm
closes #1952
4d8591b 
add start index to enumerate
@prudhomm
up install dirs #1946
c37835f
@prudhomm
define as PLUGIN as well
7c819e6 
Fix dll loader for mor plugins if .so not present #1946

skip feelpp
skip tests
skip toolboxes
@prudhomm
propgata feelpp dirs
06f6d83 
Fix dll loader for mor plugins if .so not present #1946
@prudhomm
up Fix dll loader for mor plugins if .so not present #1946
792a9e3 
fix online run
plugins in libdir for now
skip feelpp
skip tests
skip toolboxes
@prudhomm
Add tool to print information about feelpp installation closes #1959
04f5ab5
@prudhomm
Info::libdir() and similar does not return the proper directory on De…
ab8fce9 
…bian/Ubuntu closes #1958
@prudhomm
add some more info
e6808ea 
Info::libdir() and similar does not return the proper directory on Debian/Ubuntu closes #1958

[ci skip]
@prudhomm
add prefix to plugin.dir default value
fbc46a3 
Fix dll loader for mor plugins if .so not present #1946

skip feelpp
skip tests
skip toolboxes
skip python
@vincentchabannes vincentchabannes merged commit bc6f72e into develop Sep 27, 2022
@vincentchabannes vincentchabannes deleted the 1946-fix-dll-loader-for-mor-plugins-if-so-not-present branch September 27, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentchabannes vincentchabannes vincentchabannes approved these changes

Assignees

@prudhomm prudhomm

Labels
env: cmake build environment cmake module:crb
Projects
Feel++
Status: Done
Milestone
v110
2 participants
@prudhomm @vincentchabannes