Requirements before resolving 1892: compute view factor for rht #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- raytracing view factor - unobstructed view factor Compute view factor for RHT #1892 /cc @feelpp/rht
added cavities with markers and type of vf computation
here is the log
```
I0725 09:29:03.847306 1238354 rht.cpp:49] material Post
I0725 09:29:03.851155 1238354 rht.cpp:49] material Fin_1
I0725 09:29:03.854034 1238354 rht.cpp:49] material Fin_2
I0725 09:29:03.856902 1238354 rht.cpp:49] material Fin_3
I0725 09:29:03.859740 1238354 rht.cpp:49] material Fin_4
I0725 09:29:03.862596 1238354 rht.cpp:60] flux Gamma_root: {"expr":"1"}
I0725 09:29:03.865147 1238354 rht.cpp:70] convective_heat_flux Gamma_ext: {"Text":"0","h":"1"}
I0725 09:29:03.873054 1238354 rht.cpp:82] radiative_heat_flux Cavity_1: {"markers":["Cavity_1_1","Cavity_1_2"],"viewfactor":{"type":"RayTracing"}}
I0725 09:29:03.873066 1238354 rht.cpp:82] radiative_heat_flux Cavity_2: {"markers":["Cavity_2_1","Cavity_2_2"],"viewfactor":{"type":"raytracing"}}
```
/cc @feelpp/rht
…/feelpp/feelpp into 1892-compute-view-factor-for-rht
- add BC RHT specs - add BC RHT in integrate
- radiative_enclosure_heat_flux - radiative_blackbody_heat_flux
…te-them-on-the-fly' into 1892-compute-view-factor-for-rht
- add json spec for fin2d and up fin.cfg - add json spec for fin3d and up fin3d.cfg - add json specs more generally @prudhomm
…/feelpp/feelpp into 1892-compute-view-factor-for-rht
not using parameters section [ci skip]
not tested yet - compiling ok [ci skip]
- add test for cylindrical cavity (non-zero diagonal vf) - comment tests for raytracing view factors
prudhomm
changed the title
|
The current status of the branch will not resolve issue 1892. However, in order to include changes to solve the other three issues, I think that a first merge could be beneficial. |
prudhomm
changed the title
|
@lberti I just update the title of the PR and updated the description |
|
I also updated the menus on the right |
|
@prudhomm CI seems to fail because the |
|
@vincentchabannes I could not understand how to solve the problem concerning the test on view factors on Buildkite |
prudhomm
approved these changes
Feb 24, 2023
use feelpp procedure and link to nanoflann
skip toolboxes skip mor skip python
prudhomm
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It contains:
it closes the following issues