Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unobstructed view factor computation #1910

Closed
prudhomm opened this issue Jul 21, 2022 · 1 comment · Fixed by #2039
Closed

add unobstructed view factor computation #1910

prudhomm opened this issue Jul 21, 2022 · 1 comment · Fixed by #2039
Assignees
@prudhomm @lberti @MichelFouquembergh @vbontemp
Labels
✨ type:feature 🧰 toolbox:heat

Comments

@prudhomm
Copy link
Member

prudhomm commented Jul 21, 2022 •
edited
Loading

in case of unobstructed planar surfaces, view factors can be computed with quadrature formulas. The diagonal of the VF matrix is 0 since a planar surface does not see itself.

this needs #1904 to simplify integral computations
This was referenced Jul 28, 2022
Closed
Closed
prudhomm added a commit that referenced this issue Jul 29, 2022
@prudhomm
up Compute ray tracing view factor for RHT #1892
28c679c 
- work on add unobstructed view factor computation #1910
- work on Add design of view factor classes #1915
- add tests (still not working but compiling)
@prudhomm
Copy link
Member Author

The implementation is done, it now needs to be tested. Some tests are implemented and are being debogged

lberti added a commit that referenced this issue Sep 27, 2022
@lberti
up unobstructed testcase #1910
788c949
lberti added a commit that referenced this issue Sep 27, 2022
@lberti
add quadrature weights and context update #1910
515a64f
lberti added a commit that referenced this issue Sep 27, 2022
@lberti
fix testcase vf unobstructed and initialise vf matrix to 0 #1910
6d81cf4
lberti added a commit that referenced this issue Oct 3, 2022
@lberti
Up single area integration and testcase #1910
8fb9fc4
@prudhomm prudhomm mentioned this issue Nov 16, 2022
Open
72 tasks
lberti added a commit that referenced this issue Dec 23, 2022
@lberti
add unobstructed view factor computation #1910
538a592 
- allow 3d (only!) self-viewing surface VF computation
lberti added a commit that referenced this issue Jan 23, 2023
@lberti
#1910 unobstructed view factor
084d70b 
- add test for cylindrical cavity (non-zero diagonal vf)
- comment tests for raytracing view factors
@lberti lberti mentioned this issue Jan 26, 2023
Merged
lberti added a commit that referenced this issue Feb 2, 2023
@lberti
#1910
c298280 
- fix case cube unobstructed VF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prudhomm prudhomm

@lberti lberti

@MichelFouquembergh MichelFouquembergh

@vbontemp vbontemp

Labels
✨ type:feature 🧰 toolbox:heat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Requirements before resolving 1892: compute view factor for rht feelpp/feelpp
4 participants
@prudhomm @lberti @MichelFouquembergh @vbontemp