resolves 2078: port to c++20 on homebrew, petsc 3.19, nlopt and range-v3 #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor ExporterEnsight to use fmt library and remove use of deprecated sprintf #2087. This commit replaces calls to the outdated and insecure sprintf function with the modern fmt library. This change improves the overall security of the program, ensuring that we don't leave our application open to buffer overflows. Additionally, this change should improve the speed and readability of the code.
Replace the deprecated `fs::copy_option` with `fs::copy_options` in `feelfilters/geo.hpp`. The function `geo(Ts&&... v)` now uses `fs::copy_options::none` to copy files.
Add nlopt as a build target and link its library to feelpp_contrib. ALIAS feelpp_nlopt library is installed and interfaces are set to include its directories. FEELPP_ENABLED_OPTIONS_CONTRIB is updated to include nlopt/contrib.
5 tasks
prudhomm
added
cpp20
prudhomm
changed the title
prudhomm
changed the title
vincentchabannes
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here are the quickstart tests on homebrew, unfortunately mumps in parallel crashes with petsc on ventura, so I ran only the sequential ones on homebrew