Debugger hides current method and buttons

[akgrant43]

The debugger doesn't size method views in the stack well, making it difficult to use:

• It will sometimes size the current method view such that the buttons are fully visible, e.g. debug1.png, below.

• The red underline, indicating the next message to be sent, is sometimes hidden by the buttons. In debug1,png (above), #atEnd is underlined as the next message to be sent. The stream is at the end, so stepping over it will move the highlight to the end of the method (^result). However the underline is hidden by the buttons, see debug2.png (below).

The cursor changes to an up-down arrow when it is placed over the grey drag bar at the bottom of the view, however it isn't actually possible to resize the view, so there's no way to make the highlights visible (I'll try and make an animated gif to show this).

[akgrant43]

Short animation of not resizing the debugger :-)

(yes, I am holding the mouse button down :-))

Version info:

OS: Ubuntu 16.04
gtoolkit: 2019-03-19 13:40 fd03b1f
gtoolkit-debugger: 2019-03-27 16:51 b5d353050c17c2a37094dc11c9a8d275dcc8e2f1
Pharo 7.0.2
Build information: Pharo-7.0.2+build.152.sha.890f474a81f116ead0e68c8de77790aef4e9a752 (64 Bit)

[girba]

The method coder does not resize anymore because it is not wanted. We should remove the resizer.

[girba]

In the first picture, I believe the problem is that method is larger than what fits in the window. At the moment, we do not resize the window. But, it should be possible to scroll to see the end of the method. Can you confirm that it's possible?

[akgrant43]

In the first picture, I believe the problem is that method is larger than what fits in the window. At the moment, we do not resize the window. But, it should be possible to scroll to see the end of the method. Can you confirm that it's possible?

Scrolling causes the entire stack to move up and down. The method itself doesn't move relative to its view, so I still can't see the end of the method.

[girba]

I am not sure I understand. Do you have a concrete case for me to reproduce it? Or maybe you just show me :)

[akgrant43]

In the attached gif the highlight isn't visible under the last line (^result) (The buttons aren't hidden like in the example at the start of this issue).

My understanding from what you said is that if I try scrolling up and down, the text in the current method should scroll, so what I see is the red underline under "^result", the very end of the method. But instead the whole stack scrolls up and down.

[girba]

Aha. I do not think ^result should be highlighted in that method.

When the result should be highlighted it should appear like this:

What happens if you step over once in that method?

[akgrant43]

Hi Doru,

The example I gave above is from when first entering the method, so the entire method is highlighted (and "^result" should be included in that).

If I step over once the first message is highlighted:

(This actually raises another issue: why do I have to Step Over once to get to the first method? In Pharo 8 the first method is initially highlighted).

In the next animation, "self atEnd" will return true, so it will skip the block and highlight "^return". Unfortunately the gif software doesn't visually indicate when the mouse button is pressed, but you can see the stack top changing from "GtBuffer..." to "a ByteArray".

I Step Over once more and it returns to the calling method (DoIt):

[girba]

We now have an extra padding at the bottom of the editor, and we removed the resizer as we do not use it.