extract method from inspector passes inst var as argument #3701

j-brant · 2024-03-26T19:10:59Z

If you extract a method from an inspector snippet and it references an instance variable, the instance variable is passed as an argument to the method. For example, if you have array size - self size as the snippet in an OrderedCollection inspector, it should create an extracted method that takes no arguments, but instead produces:

The text was updated successfully, but these errors were encountered:

…d method args

j-brant · 2024-03-26T19:14:04Z

Metacello new baseline: 'GToolkitForPharo9'; repository: 'github://feenkcom/gtoolkit:v1.0.632/src'; load All commits (including upstream repositories) since last build: feenkcom/Bloc@ab794e by Aliaksei Syrel Merge 6e1049837dfb9650503ecb8bce72b68ad9dafba7 feenkcom/Bloc@fa157b by Aliaksei Syrel [#3673] un-hover elements when drag leave them feenkcom/bloc-pac@d732ee by Aliaksei Syrel [#3696] whenHorizontalDroppedDo: emits "cursor" index feenkcom/Brick@f4c8d9 by Aliaksei Syrel [#3696] add tab drop handler to the space tab group feenkcom/gtoolkit-phlow@45771d by John Brant fix for scrolling for remote text views feenkcom/gtoolkit-phlow@9d6d31 by John Brant adding scrollAndHighlight: to phlow text editor view feenkcom/gtoolkit-phlow@e203a7 by Don Roberts Optimize GtPhlowDefiningMethodsCollection [[#3693]] feenkcom/gtoolkit-coder@b85850 by Andrei ChiÈ� Add an inspect action to coder addon views feenkcom/gtoolkit-coder@38d7c8 by Andrei ChiÈ� Sort coder extensions by the pragma argument and the method selector name j-brant/SmaCC@75b0b9 by John Brant java parser updates to handle """ strings, switch expressions, and updated try feenkcom/gt4pharo@d5d772 by Andrei ChiÈ� Merge ee9bba7f9c51525bba678e86d5e1ffc59e019d87 feenkcom/gt4pharo@1becdb by Andrei ChiÈ� Move the highlight methods to GToolkit-Pharo-Coder-AddOns feenkcom/gt4pharo@ee9bba by John Brant Merge 6f6b709ffa4ce3f2a0c84301c25576d76947c702 feenkcom/gt4pharo@537401 by John Brant [#3701] don't include instance variables as extracted method args feenkcom/gt4pharo@6f6b70 by Andrei ChiÈ� Move the node highlight logic to GtSmalltalkSourceCoder feenkcom/gt4pharo@114692 by Andrei ChiÈ� Show the shortcut for the class browse action feenkcom/gt4pharo@a0d0e3 by Andrei ChiÈ� Move navigation methods to GtSmalltalkSourceCoder feenkcom/gt4pharo@e1ada3 by Andrei ChiÈ� Move logic for selecting and moving statements to GtSmalltalkSourceCoder feenkcom/gt4pharo@363d72 by Andrei ChiÈ� Remove duplicated shortcuts in GtPharoSnippetCoder feenkcom/gt4pharo@fd891f by Andrei ChiÈ� Introduce a GtSmalltalkSourceCoder feenkcom/gt4pharo@7b21aa by Andrei ChiÈ� Update coder addons order feenkcom/gt4pharo@d9af51 by Andrei ChiÈ� Extract the coder logic for browsing senders/implementors to TGtPharoSourceCoderAstNodesDetection feenkcom/gtoolkit-presenter@0be4d6 by Don Roberts Optimize GtPhlowDefiningMethodsCollection [[#3693]] feenkcom/gtoolkit-inspector@3c9ed0 by Alistair Grant Merge remote-tracking branch 'origin/main' feenkcom/gtoolkit-inspector@7e90c8 by Alistair Grant TaskAtQueue>>gtItemsFor: add update button feenkcom/PythonBridge@729227 by Don Roberts Catch errors when python source not available [[fenkcom/gtoolkit#3700]] feenkcom/gtoolkit-remote-python@a76c4e by Don Roberts Store PBMethodObject instead of view [[fenkcom/gtoolkit#3700]] feenkcom/gtoolkit-remote-python@500373 by Don Roberts Remote python views display source [[fenkcom/gtoolkit#3700]] feenkcom/gtoolkit-remote@69ce8b by John Brant fix for scrolling for remote text views feenkcom/gtoolkit-remote@dab057 by John Brant adding scrollAndHighlight: to phlow text editor view feenkcom/gtoolkit-remote@3bd653 by Don Roberts Optimize GtPhlowDefiningMethodsCollection [[#3693]] feenkcom/gtoolkit-visualizer@cbb827 by Don Roberts Optimize GtPhlowDefiningMethodsCollection [[#3693]] feenkcom/gtoolkit-releaser@dfbbbb by Juraj Kubelka better project version string example [#3679] feenkcom/gtoolkit-releaser@cb2900 by Juraj Kubelka print project version has `--line-ending=false` option [#3679] feenkcom/lepiter@30319b by Andrei ChiÈ� Merge 6fb9c4f4e14fb5a05e060b287fca4912af3cd587 feenkcom/lepiter@787163 by Andrei ChiÈ� Use GtSmalltalkSourceCoder for the PharoLink coder feenkcom/lepiter@6fb9c4 by Tudor Girba improve the json view #3695 feenkcom/lepiter@f4641b by Tudor Girba add maximizer to the wardley map snippet #3695 feenkcom/lepiter@a7ce96 by Tudor Girba add ability to delete the file of a page from a duplicated page id error feenkcom/lepiter@283e8b by Tudor Girba add database to the duplicated page id error and add inspect file action feenkcom/lepiter@7ada5b by Tudor Girba add disk files view to the monitor feenkcom/lepiter@deaa4f by Tudor Girba add database key to the duplicate page exception view feenkcom/gt4petitparser2@f45ed9 by Andrei ChiÈ� Update coder addons order feenkcom/gtoolkit-remoterunner@c51d0b by Alistair Grant GtRemoteRunner>>stop stop any running workers, GtRrTimeoutManager go idle if the runner is stopped. feenkcom/gt4famix3@b89144 by John Brant use new scrolling for remote text views feenkcom/gtoolkit-world@bdc070 by Aliaksei Syrel Merge 7367b533dcc43208c7d1d522da8f17966753b4b0 feenkcom/gtoolkit-world@1b4355 by Aliaksei Syrel [#3696] enable tab drag and drop feenkcom/gtoolkit-world@7367b5 by Don Roberts Optimize GtPhlowDefiningMethodsCollection [[#3693]] feenkcom/gt4gemstone@a200b3 by Andrei ChiÈ� Add extensions for browsing local hierarchy implementors and references feenkcom/gt4gemstone@732fee by Andrei ChiÈ� Add a menu for browsing local slot references feenkcom/gt4gemstone@4a6c32 by Andrei ChiÈ� Move the node highlight logic to GtSmalltalkSourceCoder feenkcom/gt4gemstone@aabe63 by Andrei ChiÈ� Use UndefinedObject by default for the local behaviour of GemStone snippets feenkcom/gt4gemstone@e4e2cf by Andrei ChiÈ� Show the shortcut for the class browse action feenkcom/gt4gemstone@6b51c0 by Andrei ChiÈ� Move the navigation logic to the superclass feenkcom/gt4gemstone@23624b by Andrei ChiÈ� Enable shortcuts for moving and selecting statements in GemStone snippets feenkcom/gt4gemstone@dc8f36 by Andrei ChiÈ� Use GtSmalltalkSourceCoder for the GemStone coder feenkcom/gt4gemstone@7557e4 by Andrei ChiÈ� Add formatting for GemStone snippets [#3697] feenkcom/gt4gemstone@1fffd9 by Andrei ChiÈ� Use TGtPharoSourceCoderAstNodesDetection in the GemStone coder to implement senders/references feenkcom/gt4aws@77fb50 by veit.heller Add CPU usage for ec2 instances feenkcom/gt4aws@6669d3 by Alistair Grant Add GtAwsServicesImporter class>>services 26fe86 by Aliaksei Syrel Merge branch 'main' of github.com:feenkcom/gtoolkit # Conflicts: # lepiter/wmr9gimw6g205bh5a1hacnoh.lepiter 9d3f55 by Aliaksei Syrel [#3696] add World page to the GT book

Metacello new baseline: 'GToolkitForPharo9'; repository: 'github://feenkcom/gtoolkit:v1.0.636/src'; load All commits (including upstream repositories) since last build: feenkcom/pharo-futures@3edda1 by Aliaksei Syrel remove inform exception handler feenkcom/pharo-futures@775b21 by Aliaksei Syrel add empty executionConfiguration: feenkcom/pharo-futures@91aab5 by Aliaksei Syrel [#2852] make error handling configurable feenkcom/pharo-futures@8642e8 by Aliaksei Syrel Merge a5984ed0f9f10fe75db2132468ddb4a4cca91184 feenkcom/pharo-futures@0480ca by Aliaksei Syrel [#3703] add AsyncForkPollFuture feenkcom/Bloc@f14959 by Aliaksei Syrel Merge 3d473fe4afd5881c217568d55e317904a29bf81c feenkcom/Bloc@5fe034 by Aliaksei Syrel improve an error when children have a parent feenkcom/Bloc@3d473f by Oscar Nierstrasz Fixed typo feenkcom/gtoolkit-utility@99cdca by Juraj Kubelka Merge 04014a99de68ebc4272a28f48e9d066f4308c39d feenkcom/gtoolkit-utility@7f1ec7 by Juraj Kubelka add `GtAutomaticNetworkProxySetter` [#3704] feenkcom/gtoolkit-utility@04014a by Veit Heller Add `#withIndexDo:` to groups feenkcom/Brick@397c88 by Aliaksei Syrel [#3702] lists allow users to pass execution configuration with a stream feenkcom/gtoolkit-coder@31b20e by Aliaksei Syrel Merge 9da987e443fa5864771386d8dfd37d094f02192e feenkcom/gtoolkit-coder@3277ba by Aliaksei Syrel [#3574] add addons execution configuration feenkcom/gtoolkit-coder@9da987 by John Brant [#3705] create GtRefactoryChangeManager to undo/redo code changes j-brant/SmaCC@5d21c0 by John Brant java parser changes for sealed classes j-brant/SmaCC@3898d1 by John Brant java parser changes for records and a few other items feenkcom/gt4pharo@fd9ab8 by Aliaksei Syrel Merge c5f1b83ec5c4e1fa2b01cb8892579606f6663a6b feenkcom/gt4pharo@4abd4e by Aliaksei Syrel [#3574] addons should be computed in their own worker feenkcom/gt4pharo@c5f1b8 by John Brant [#3701] example for extracting from inspector snippet feenkcom/gt4pharo@be9cd0 by John Brant [#3705] create GtRefactoryChangeManager to undo/redo code changes feenkcom/gtoolkit-presenter@81654f by Oscar Nierstrasz Fixed slowdown in actions due to computation of slides. feenkcom/gtoolkit-debugger@7ee7b3 by Aliaksei Syrel Merge be2d01ff3b936f6360150f068752c37256099eeb feenkcom/gtoolkit-debugger@fa20d8 by Aliaksei Syrel [#3702] add debugger specific scrolling list worker feenkcom/lepiter@5befda by Juraj Kubelka Merge 67f582fe2919c4363d7ddb823b104ee2b8b4e93a feenkcom/lepiter@3d6ae3 by Juraj Kubelka `LeDatabaseRegistrations` search pragmas also in superclasses [#3679] feenkcom/lepiter@67f582 by Oscar Nierstrasz Added indentAll and unindentAll feenkcom/gtoolkit-demos@6af1f8 by Oscar Nierstrasz Reverted bad change feenkcom/gtoolkit-demos@770e42 by Oscar Nierstrasz Merge 23184ec13e3ebfb238451aa7088f0e96c8f8cd6b feenkcom/gtoolkit-demos@021666 by Oscar Nierstrasz Added sugiyama laout feenkcom/gtoolkit-demos@23184e by Oscar Nierstrasz More slides feenkcom/gtoolkit-demos@22d0b4 by Oscar Nierstrasz Fixed slowdown in actions due to computation of slides. feenkcom/gtoolkit-demos@c78f4c by Oscar Nierstrasz Fixed slowdown in actions due to computation of slides. feenkcom/gtoolkit-demos@3a1209 by Oscar Nierstrasz Refactored the first half of the intro slides feenkcom/gt4famix3@144c2b by John Brant updating java importer for records feenkcom/gt4famix3@a24095 by John Brant adding Java package to baseline feenkcom/gtoolkit-world@a7f43c by Aliaksei Syrel [#2852] in the workers view show if worker is waiting on a semaphore feenkcom/gtoolkit-world@d6f73c by Aliaksei Syrel Merge 29c28c40cc2dc8c35e0f30ac20160d271f766f56 feenkcom/gtoolkit-world@25c81f by Aliaksei Syrel [#3703] add AsyncForkPollFuture feenkcom/gt4gemstone@66e14a by Andrei ChiÈ� Add explicit labels for abort and commit actions feenkcom/gt4aws@4ee43d by veit.heller Add cpuUsage cache to ec2 instance feenkcom/gt4aws@a2333c by veit.heller Add `#average` to maximum data point group

j-brant added the bug label Mar 26, 2024

j-brant self-assigned this Mar 26, 2024

j-brant added a commit to feenkcom/gt4pharo that referenced this issue Mar 26, 2024

[feenkcom/gtoolkit#3701] don't include instance variables as extracte…

537401c

…d method args

j-brant closed this as completed Mar 26, 2024

girba added this to the v1.0 milestone Mar 26, 2024

j-brant added a commit to feenkcom/gt4pharo that referenced this issue Mar 27, 2024

[feenkcom/gtoolkit#3701] example for extracting from inspector snippet

c5f1b83

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

extract method from inspector passes inst var as argument #3701

extract method from inspector passes inst var as argument #3701

j-brant commented Mar 26, 2024

j-brant commented Mar 26, 2024

extract method from inspector passes inst var as argument #3701

extract method from inspector passes inst var as argument #3701

Comments

j-brant commented Mar 26, 2024

j-brant commented Mar 26, 2024