fork to child process after accepting new connection request. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnection will have its own process.
|
Whoops. This creates a bunch of zombie processes.
I will address in an update to this PR. |
|
Keep me posted on how it goes! |
|
Ok, this is good to go now. To verify forking, you can hammer reload on your browser and observe that you cannot bring down the server. Additionally, you can comment out the process reaping code and use To verify zombie process reaping, refresh the page a few times and then do a |
|
Looks really good, thanks for the contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each connection will have its own process and a crashed process will not crash the server.
Closes #4.