Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bloc): deprecate BlocOverrides #3469

Merged
merged 4 commits into from Aug 6, 2022
Merged

Conversation

felangel
Copy link
Owner

@felangel felangel commented Aug 2, 2022

Status

READY

Breaking Changes

NO

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🌅 Deprecation
  • 🗑️ Chore

@felangel felangel added deprecation A public API is being deprecated pkg:bloc This issue is related to the bloc package labels Aug 2, 2022
@felangel felangel self-assigned this Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #3469 (5e51595) into master (16e7bb3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master     #3469    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           30         8    -22     
  Lines          731       196   -535     
==========================================
- Hits           731       196   -535     
Impacted Files Coverage Δ
packages/bloc/lib/src/bloc.dart 100.00% <100.00%> (ø)
packages/bloc/lib/src/bloc_base.dart 100.00% <100.00%> (ø)
packages/bloc/lib/src/bloc_overrides.dart 100.00% <100.00%> (ø)
packages/bloc_test/lib/src/mock_bloc.dart
packages/bloc_test/lib/src/bloc_test.dart
packages/flutter_bloc/lib/src/bloc_listener.dart
...ckages/hydrated_bloc/lib/src/hydrated_storage.dart
...ages/flutter_bloc/lib/src/multi_bloc_listener.dart
packages/bloc_test/lib/src/when_listen.dart
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@felangel felangel marked this pull request as ready for review August 2, 2022 21:22
wolfenrain
wolfenrain previously approved these changes Aug 3, 2022
renancaraujo
renancaraujo previously approved these changes Aug 4, 2022
@felangel felangel dismissed stale reviews from renancaraujo and wolfenrain via 3aa9425 August 5, 2022 03:57
@felangel felangel merged commit d62d947 into master Aug 6, 2022
@felangel felangel deleted the feat/deprecate-blocoverrides branch August 6, 2022 02:07
maximveksler pushed a commit to maximveksler/bloc that referenced this pull request Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation A public API is being deprecated pkg:bloc This issue is related to the bloc package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants