Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tips into contributing #609

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Add tips into contributing #609

merged 2 commits into from
Oct 24, 2019

Conversation

tenhobi
Copy link
Collaborator

@tenhobi tenhobi commented Oct 24, 2019

Status

READY

Breaking Changes

NO

Description

For contributing a translation might be helpful to provide a default set of TODOs people can copy to their PRs.

@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #609 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #609   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         214    214           
=====================================
  Hits          214    214

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5c940...e5c9f1e. Read the comment docs.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-Authored-By: Felix Angelov <felangelov@gmail.com>
@tenhobi tenhobi requested a review from felangel October 24, 2019 20:40
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, thanks! 👍

@felangel felangel merged commit 06b98b2 into felangel:master Oct 24, 2019
@felangel felangel added documentation Documentation requested enhancement New feature or request labels Oct 24, 2019
@tenhobi
Copy link
Collaborator Author

tenhobi commented Oct 24, 2019

Thanks for merging!

@tenhobi tenhobi deleted the contributing-docs branch October 24, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation requested enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants