[SQL] Use standard SQL semantics for division #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we really want safe arithmetic we should define functions for that purpose. Note that the Calcite SAFE_ADD and co. functions are unsuitable for our purposes since they cast everything to either BIGINT, DECIMAL or DOUBLE. |
abhizer
approved these changes
Dec 28, 2023
Comment on lines
425
to
432
| if (iRightType.isOne(rightLit)) { | ||
| result = left; | ||
| } else if (iRightType.isZero(rightLit)) { | ||
| this.errorReporter.reportWarning(expression.getSourcePosition(), "Division by zero", | ||
| " Division by constant zero value."); | ||
| } else if (iRightType.isOne(rightLit)) { | ||
| result = left; | ||
| } |
There was a problem hiding this comment.
We check the same condition twice here?
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mihaibudiu
force-pushed
the
issue1200
branch
from
ed71402
to
0053247
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a user-visible change (yes/no): yes
Fixes #1200
Initially I thought that division is a problematic operation in SQL because it throws on division by 0, so I redefined it to return NULL. Turns out that most SQL operations can throw, so there is no point in only changing the semantics of division. This PR reverts the typing and semantics of division to its standard SQL definition.