Log SQL metrics #1875
Merged
Log SQL metrics #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gz
approved these changes
Jun 14, 2024
benchmark/feldera-sql/run.py
Outdated
| if elapsed - last_metrics > metricsinterval: | ||
| last_metrics = elapsed | ||
| metrics_list = [pipeline_name, elapsed, global_metrics["rss_bytes"], global_metrics["buffered_input_records"], global_metrics["total_input_records"], global_metrics["total_processed_records"]] | ||
| disk_index = 6 |
There was a problem hiding this comment.
this seems a little brittle maybe it should be disk_index = len(metrics_list)+1 or similar?
There was a problem hiding this comment.
I'm going to go with this; the reason being that we don't necessarily know what order we are receiving things in, so we want to maintain the same order in the list of lists which will be output as a CSV.
| metrics_list += [""] | ||
| for s in stats["metrics"]: | ||
| if s["key"] == "disk.total_files_created": | ||
| metrics_list[disk_index] = s["value"]["Counter"] |
There was a problem hiding this comment.
or this here just does .push() instead of append by indexing?
Signed-off-by: Matei <matei@feldera.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a user-visible change (yes/no): no
This pull request goes with another one in the benchmarks repository: https://github.com/feldera/benchmarks/pull/4
Changes in this PR:
These files are then used by the benchmarks repository to generate new graphs. See that PR for more details.