Filenames with spaces cause fatal errors

[Zetten]

After adding a Mercurial remote to an existing Git repo, and git --fetching to synchronise, a git push --tags fails in two separate locations due to the existence of filenames with spaces in the changesets.

The errors occur in the parse_commit(parser) function, where the diff stat lines are split on whitespace. The existence of a filename with a space character causes the error (and a similar error later on line 624):

Traceback (most recent call last):
  File "/usr/local/bin/git-remote-hg", line 805, in 
    sys.exit(main(sys.argv))
  File "/usr/local/bin/git-remote-hg", line 795, in main
    do_export(parser)
  File "/usr/local/bin/git-remote-hg", line 689, in do_export
    parse_commit(parser)
  File "/usr/local/bin/git-remote-hg", line 577, in parse_commit
    t, path = line.split(' ')
ValueError: too many values to unpack
error: fast-export died of signal 13
fatal: Error while running fast-export

Setting the maxsplit value for these splits is my quick fix, but there may be a better way for a more experienced python dev. I'll add a pull request just in case.

[fingolfin]

Good catch. Unfortunately, felipe has not shown any signs of activity in the past months. You may be better off trying to get this patch integrated right into the copy of felipe's git-remote-hg now shipped as part of git.git (in the contrib dir).

Or you could try out our "fork" of this tool, which adds many improvements and fixes over this code here (but it also drops the hg-git compatibility mode, so if you need that, this won't be for you). In particular, I just pushed a commit there which fixes the issue you are reporting here in gitifyhg.

[Zetten]

Unfortunately the hg-git mode is kind of essential for a current use case. I might be able to work around that sometime in the future.

In any event I'll see about submitting the patch to git directly since it's definitely a failure case in git-remote-hg.

[felipec]

Thanks. I've merged the patch, makes sense to me.