Add try/except around export_ref when accessing repo[tag]

[ambakshi]

I tried to open an issue in your repo, but it looks like you don't have that enabled. I added an issue here:

ambakshi#1

I don't know what the real cause is, but it looks like some tag the tool thought it imported is missing. The repo was perfectly fine after I added the try/except. The tool doesn't print a lot while exporting and since it fixed my problem I thought I'd see if you want to merge it or have any ideas.

Thanks,
Amit

[felipec]

I think the repo settings are inherited. I've enabled it now.

I'm not sure about the patch, I think you should do something like this:

@@ -474,6 +480,7 @@ def do_list(parser):
     print "? refs/heads/%s" % bmark

     for tag, node in repo.tagslist():
+        print >> sys.stderr, tag
         if tag == 'tip':
             continue
         print "? refs/tags/%s" % tag

And paste the output of that. I think there must be something wrong with the format of certain tag.

That exception should never occur, because we only request the tags that told git we have.

[ambakshi]

Thanks Felipe. I'm not at all familiar with hg, and thought the try block
is a hack :) I'll try your code tomorrow and let you know.

Cheers,
Amit

On Nov 21, 2012, at 2:41, Felipe Contreras notifications@github.com wrote:

I think the repo settings are inherited. I've enabled it now.

I'm not sure about the patch, I think you should do something like this:

@@ -474,6 +480,7 @@ def do_list(parser):
print "? refs/heads/%s" % bmark

for tag, node in repo.tagslist():

• print >> sys.stderr, tag if tag == 'tip': continue print "?
  refs/tags/%s" % tag

And paste the output of that. I think there must be something wrong with
the format of certain tag.

That exception should never occur, because we only request the tags that
told git we have.

—
Reply to this email directly or view it on
GitHubhttps://github.com//pull/1#issuecomment-10592386.

[ambakshi]

The tag "2.3.9.54 IOVP 5.0 submission" seems to be the culprit.

The Parser class is return line.split()[1] for the tagname so it's just getting the 2.3.9.54. I tried creating a tag with a space in git, and it doesn't seem to like that.

Again, not at all familiar with how this stuff works. Should be split the ref and ditch the rest when calling export_tag?

[felipec]

Try line.split(' ', 1)

[ambakshi]

I tried that it didn't work. It could cause other issues too, like having
multiple tags that start with the same string then a space. Since git
doesn't support spaces in tags, maybe those tags should be ignored and user
is warned? It's a corner case, nobody in their right mind uses spaces.

Thanks,
Amit

Sent from my iPhone

On Nov 21, 2012, at 20:09, Felipe Contreras notifications@github.com
wrote:

Try line.split(' ', 1)

—
Reply to this email directly or view it on
GitHubhttps://github.com//pull/1#issuecomment-10623247.

[felipec]

Yeah, there should be a ref_isvalid() or something, and those should be skipped and the user warned. Git already does that, but not when spaces are involved.

[felipec]

I don't know what happened in this report, but if the problem was tag with spaces, that should be fixed now.