feat: honor npm_config_arch if set
#193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecrs
force-pushed
the
npm_config_arch
branch
5 times, most recently
from
0b8f562
to
3c5d6a6
Compare
Since our dev dependencies are dropping support for node 10 and 12, we are dropping support for node 10 and 12 as well to simplify the maintenance. This also add node 16 and node 18 to the test matrix and upgrade npm to 9.
Previously, if you had set `npm_config_arch` for whatever reason, bindl would simply ignore it and download the binaries for all platforms and archs. Now, when `npm_config_arch` is set, bindl will only download the binaries for the current platform and the arch speficied by the `npm_config_arch` environment variable.
felipecrs
force-pushed
the
npm_config_arch
branch
from
fd3909b
to
69718d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #189