Allow frames to scroll smoothly into view (hotwired#607)

feliperaul · Jul 15, 2022 · 39fe418 · 39fe418
1 parent 2d5cdda
commit 39fe418
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/src/core/frames/frame_renderer.ts b/src/core/frames/frame_renderer.ts
@@ -36,9 +36,10 @@ export class FrameRenderer extends Renderer<FrameElement> {
     if (this.currentElement.autoscroll || this.newElement.autoscroll) {
       const element = this.currentElement.firstElementChild
       const block = readScrollLogicalPosition(this.currentElement.getAttribute("data-autoscroll-block"), "end")
+      const behavior = readScrollBehavior(this.currentElement.getAttribute("data-autoscroll-behavior"), "auto")
 
       if (element) {
-        element.scrollIntoView({ block })
+        element.scrollIntoView({ block, behavior })
         return true
       }
     }
@@ -64,3 +65,11 @@ function readScrollLogicalPosition(value: string | null, defaultValue: ScrollLog
     return defaultValue
   }
 }
+
+function readScrollBehavior(value: string | null, defaultValue: ScrollBehavior): ScrollBehavior {
+  if (value == "auto" || value == "smooth") {
+    return value
+  } else {
+    return defaultValue
+  }
+}