-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shell_sort #87
add shell_sort #87
Conversation
Hi, could you please fix the linting errors? (https://travis-ci.org/felipernb/algorithms.js/builds/32082065) You can check it locally by runing |
Sorry I did't notice this problem .Thank you for your remind.This is my first time to contribute to project, many things I don't understand . Can I ask a question? D:\repositories\algorithms.js>make D:\repositories\algorithms.js\node_modules.bin_mocha:2 SyntaxError: Unexpected token ILLEGAL |
Hi, I've merged your commit manually and squashed all commits in a single one. Thanks for the contribution! Regarding the error, I don't really know what's the problem buut it seems that the code coverage tool doesn't work well with Windows. I'm gonna try to take a look and get back to you :) |
OK ! Thank you . Maybe I need to use linux... |
@@ -0,0 +1,42 @@ | |||
'use strict'; | |||
|
|||
var shellSort = require('../../../algorithms/sorting/shell_sort'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat! i love test~
hello,I add a shellSort into sort,I hope can contribute to this project. : )